You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/04/22 01:34:11 UTC
Review Request 20541: Patch for KAFKA-1411
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20541/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1411
https://issues.apache.org/jira/browse/KAFKA-1411
Repository: kafka
Description
-------
1. Remove LazyInitProducerTest since the tests there are redundant from those in PrimitiveApiTest. 2. Remove AsyncProducerTest.testBrokerListAndAsync() since it returns immediately. There are other tests that cover the same functionality. 3. PrimitiveApiTest: The compression property wasn't set properly. Also, there is no need to test compression with other combinations such as encoder/multi-fetch.
Diffs
-----
core/src/test/scala/unit/kafka/integration/LazyInitProducerTest.scala c3c7631659fbd9265e45aa810d32faafe9aed1d1
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala a062f68c7f6b285fb0c63cec238882c9bc7ee246
core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 18e355501808c00b610da8346e0dd1898d5b9301
Diff: https://reviews.apache.org/r/20541/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 20541: Patch for KAFKA-1411
Posted by Jun Rao <ju...@gmail.com>.
> On April 22, 2014, 12:09 a.m., Guozhang Wang wrote:
> > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 97
> > <https://reviews.apache.org/r/20541/diff/1/?file=563930#file563930line97>
> >
> > codec should be "1"
The old producer supports both "1" and "gizp".
- Jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20541/#review40981
-----------------------------------------------------------
On April 21, 2014, 11:34 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20541/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 11:34 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1411
> https://issues.apache.org/jira/browse/KAFKA-1411
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Remove LazyInitProducerTest since the tests there are redundant from those in PrimitiveApiTest. 2. Remove AsyncProducerTest.testBrokerListAndAsync() since it returns immediately. There are other tests that cover the same functionality. 3. PrimitiveApiTest: The compression property wasn't set properly. Also, there is no need to test compression with other combinations such as encoder/multi-fetch.
>
>
> Diffs
> -----
>
> core/src/test/scala/unit/kafka/integration/LazyInitProducerTest.scala c3c7631659fbd9265e45aa810d32faafe9aed1d1
> core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala a062f68c7f6b285fb0c63cec238882c9bc7ee246
> core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 18e355501808c00b610da8346e0dd1898d5b9301
>
> Diff: https://reviews.apache.org/r/20541/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20541: Patch for KAFKA-1411
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20541/#review40981
-----------------------------------------------------------
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala
<https://reviews.apache.org/r/20541/#comment74324>
codec should be "1"
- Guozhang Wang
On April 21, 2014, 11:34 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20541/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 11:34 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1411
> https://issues.apache.org/jira/browse/KAFKA-1411
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Remove LazyInitProducerTest since the tests there are redundant from those in PrimitiveApiTest. 2. Remove AsyncProducerTest.testBrokerListAndAsync() since it returns immediately. There are other tests that cover the same functionality. 3. PrimitiveApiTest: The compression property wasn't set properly. Also, there is no need to test compression with other combinations such as encoder/multi-fetch.
>
>
> Diffs
> -----
>
> core/src/test/scala/unit/kafka/integration/LazyInitProducerTest.scala c3c7631659fbd9265e45aa810d32faafe9aed1d1
> core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala a062f68c7f6b285fb0c63cec238882c9bc7ee246
> core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 18e355501808c00b610da8346e0dd1898d5b9301
>
> Diff: https://reviews.apache.org/r/20541/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20541: Patch for KAFKA-1411
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20541/#review41060
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On April 21, 2014, 11:34 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20541/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 11:34 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1411
> https://issues.apache.org/jira/browse/KAFKA-1411
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Remove LazyInitProducerTest since the tests there are redundant from those in PrimitiveApiTest. 2. Remove AsyncProducerTest.testBrokerListAndAsync() since it returns immediately. There are other tests that cover the same functionality. 3. PrimitiveApiTest: The compression property wasn't set properly. Also, there is no need to test compression with other combinations such as encoder/multi-fetch.
>
>
> Diffs
> -----
>
> core/src/test/scala/unit/kafka/integration/LazyInitProducerTest.scala c3c7631659fbd9265e45aa810d32faafe9aed1d1
> core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala a062f68c7f6b285fb0c63cec238882c9bc7ee246
> core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 18e355501808c00b610da8346e0dd1898d5b9301
>
> Diff: https://reviews.apache.org/r/20541/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20541: Patch for KAFKA-1411
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20541/#review41417
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On April 21, 2014, 11:34 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20541/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 11:34 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1411
> https://issues.apache.org/jira/browse/KAFKA-1411
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1. Remove LazyInitProducerTest since the tests there are redundant from those in PrimitiveApiTest. 2. Remove AsyncProducerTest.testBrokerListAndAsync() since it returns immediately. There are other tests that cover the same functionality. 3. PrimitiveApiTest: The compression property wasn't set properly. Also, there is no need to test compression with other combinations such as encoder/multi-fetch.
>
>
> Diffs
> -----
>
> core/src/test/scala/unit/kafka/integration/LazyInitProducerTest.scala c3c7631659fbd9265e45aa810d32faafe9aed1d1
> core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala a062f68c7f6b285fb0c63cec238882c9bc7ee246
> core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 18e355501808c00b610da8346e0dd1898d5b9301
>
> Diff: https://reviews.apache.org/r/20541/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>