You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/25 03:30:05 UTC
[jira] [Commented] (BOOKKEEPER-1074) Remove JMX Bean

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024141#comment-16024141 ] 

ASF GitHub Bot commented on BOOKKEEPER-1074:
--------------------------------------------

GitHub user sijie opened a pull request:

    https://github.com/apache/bookkeeper/pull/161

    BOOKKEEPER-1074: Remove JMX Bean

    This change is based on #160 , the change here is: gitsha [b3be81f](https://github.com/sijie/bookkeeper/commit/b3be81fadae50f2d4a2e938c2735fa35c6c31421)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sijie/bookkeeper remove_jmx_beam

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #161
    
----
commit 88a0cc02789165f5220086244378007189f382d5
Author: Sijie Guo <si...@apache.org>
Date:   2017-05-25T02:07:27Z

    Add twitter-finagle-provider

commit fba0e92f5b586aa5885dfce072df3913b1ef3e92
Author: Sijie Guo <si...@apache.org>
Date:   2017-05-25T02:52:01Z

    Resolve the conflicts with merges

commit 085a2f59db9550b28c4bb9aa7035771f42875a1c
Author: Sijie Guo <si...@apache.org>
Date:   2017-05-25T03:05:11Z

    Add missing license header

commit b3be81fadae50f2d4a2e938c2735fa35c6c31421
Author: Sijie Guo <si...@twitter.com>
Date:   2015-06-05T17:25:16Z

    Remove JMX from bookkeeper
    
    * for compatability with zk 3.5
    * as we use StatsProvider, we don't need JMX anymore.
    
    RB_ID=682432

----


> Remove JMX Bean 
> ----------------
>
>                 Key: BOOKKEEPER-1074
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1074
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-stats
>            Reporter: Sijie Guo
>            Assignee: Leigh Stewart
>             Fix For: 4.5.0
>
>
> JMX Bean was the old fashion used for exporting metrics. It was introduced before stats-provider introduced. Now stats-provider is there. Let's remove JMX Bean.
> It is the change ported from Twitter branch.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)