You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/04/27 22:13:52 UTC
Review Request 58817: Captured AgentID from the offer by reference in
tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58817/
-----------------------------------------------------------
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/check_tests.cpp ec0d5ee78a94991c68f38174d09b41e8f2e4be35
src/tests/slave_tests.cpp 8c97dc6d088708d301dc3ccf90d413fd785b782f
Diff: https://reviews.apache.org/r/58817/diff/1/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 58817: Captured AgentID from the offer by
reference in tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58817/#review173267
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 27, 2017, 10:13 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58817/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 10:13 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/check_tests.cpp ec0d5ee78a94991c68f38174d09b41e8f2e4be35
> src/tests/slave_tests.cpp 8c97dc6d088708d301dc3ccf90d413fd785b782f
>
>
> Diff: https://reviews.apache.org/r/58817/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58817: Captured AgentID from the offer by
reference in tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58817/
-----------------------------------------------------------
(Updated May 9, 2017, 2:31 p.m.)
Review request for mesos, Gastón Kleiman and Vinod Kone.
Changes
-------
Rebased. NNTR.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/check_tests.cpp ec0d5ee78a94991c68f38174d09b41e8f2e4be35
src/tests/slave_tests.cpp 8c97dc6d088708d301dc3ccf90d413fd785b782f
Diff: https://reviews.apache.org/r/58817/diff/4/
Changes: https://reviews.apache.org/r/58817/diff/3-4/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 58817: Captured AgentID from the offer by
reference in tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58817/
-----------------------------------------------------------
(Updated May 3, 2017, 4:45 p.m.)
Review request for mesos, Gastón Kleiman and Vinod Kone.
Changes
-------
Rebased, NNTR.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/check_tests.cpp ec0d5ee78a94991c68f38174d09b41e8f2e4be35
src/tests/slave_tests.cpp 8c97dc6d088708d301dc3ccf90d413fd785b782f
Diff: https://reviews.apache.org/r/58817/diff/3/
Changes: https://reviews.apache.org/r/58817/diff/2-3/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 58817: Captured AgentID from the offer by
reference in tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58817/#review173375
-----------------------------------------------------------
Ship it!
Thanks for fixing this!
- Vinod Kone
On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58817/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 4:14 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/check_tests.cpp ec0d5ee78a94991c68f38174d09b41e8f2e4be35
> src/tests/slave_tests.cpp 8c97dc6d088708d301dc3ccf90d413fd785b782f
>
>
> Diff: https://reviews.apache.org/r/58817/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58817: Captured AgentID from the offer by
reference in tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58817/
-----------------------------------------------------------
(Updated April 28, 2017, 4:14 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Changes
-------
Rebased.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/check_tests.cpp ec0d5ee78a94991c68f38174d09b41e8f2e4be35
src/tests/slave_tests.cpp 8c97dc6d088708d301dc3ccf90d413fd785b782f
Diff: https://reviews.apache.org/r/58817/diff/2/
Changes: https://reviews.apache.org/r/58817/diff/1-2/
Testing
-------
make check
Thanks,
Alexander Rukletsov