You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Simon Willnauer (JIRA)" <ji...@apache.org> on 2011/06/17 21:25:47 UTC
[jira] [Commented] (SOLR-2589) Commenting out the section in firstSearcher generates an NPE
[ https://issues.apache.org/jira/browse/SOLR-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051271#comment-13051271 ]
Simon Willnauer commented on SOLR-2589:
---------------------------------------
Erick, good to see testing for this! :)
I wonder if you have an encoding problem I see a <?> in DirectoryFactory (Dir�ctoryFactory) in your patch.
Regarding the one line change I wonder if you could pull the "queries" named list only once, assign it to a local var and check the var for null. Tiny safe but every bit counts.
rest looks good I look forward to more patches like that with more test code than actual changes.
> Commenting out the <arr name="queries"> section in firstSearcher generates an NPE
> ----------------------------------------------------------------------------------
>
> Key: SOLR-2589
> URL: https://issues.apache.org/jira/browse/SOLR-2589
> Project: Solr
> Issue Type: Bug
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Trivial
> Attachments: SOLR-2589.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This has been around from at least 1.4.1, it just clutters up the log, it's pretty harmless but easy to fix. I'll get it done as soon as I get my account set up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org