You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karol Szkudlarek <ka...@mikronika.com.pl> on 2005/04/27 14:38:03 UTC
asking props
Hi!
Could anybody tell me what means the following svn
message:
"Asking props changed in two different filesystems".
What are the asking properties?
Greets,
Karol Szkudlarek
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] asking props (was Re: asking props)
Posted by Michael W Thelen <mi...@pietdepsi.com>.
Julian Foad wrote:
> Michael W Thelen wrote:
>> Thanks for the patch. I've filed it as issue #2302:
>
> Michael, it is very helpful of you to make sure that these patches are
> not forgotten. It occurs to me that it might be even more helpful if
> you could first send a message that just says, "Ping! Can anyone deal
> with this quickly? If not, I'll file the patch tomorrow." Sometimes
> this would provoke a committer into either committing or criticizing the
> patch, instead of just leaving it to be found (much) later in the issue
> tracker.
No problem! I'll start doing that. Thanks for suggesting it.
--
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes. -- Douglas Adams
Re: [PATCH] asking props (was Re: asking props)
Posted by Julian Foad <ju...@btopenworld.com>.
Michael W Thelen wrote:
> Thanks for the patch. I've filed it as issue #2302:
Michael, it is very helpful of you to make sure that these patches are not
forgotten. It occurs to me that it might be even more helpful if you could
first send a message that just says, "Ping! Can anyone deal with this quickly?
If not, I'll file the patch tomorrow." Sometimes this would provoke a
committer into either committing or criticizing the patch, instead of just
leaving it to be found (much) later in the issue tracker.
Just a thought.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] asking props (was Re: asking props)
Posted by Michael W Thelen <mi...@pietdepsi.com>.
Karol Szkudlarek wrote:
> OK I prepared a patch. Here is the log message:
Thanks for the patch. I've filed it as issue #2302:
http://subversion.tigris.org/issues/show_bug.cgi?id=2302
--
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes. -- Douglas Adams
[PATCH] asking props (was Re: asking props)
Posted by Karol Szkudlarek <ka...@mikronika.com.pl>.
kfogel@collab.net wrote:
> Karol Szkudlarek <ka...@mikronika.com.pl> writes:
>
>>Now it's clear to me. Thanks. The message also appears in another file:
>>libsvn_fs_fs/tree.c:1153.
>>
>>And similar two messages are located here:
>>
>>#: libsvn_fs_base/tree.c:3937 libsvn_fs_fs/tree.c:2593
>>msgid "Asking contents changed in two different filesystems"
>
>
> Thanks for noticing!
>
> Could I persuade to you to post a patch for these? See HACKING and
> http://subversion.tigris.org/mailing-list-guidelines.html#patches for
> guidelines on sending patches.
>
> If you don't have time for it, that's fine, just let us know.
>
> -Karl
>
Hi!
OK I prepared a patch. Here is the log message:
* subversion/libsvn_fs_base/tree.c
(base_contents_changed),
subversion/libsvn_fs_fs/tree.c
(fs_contents_changed): Improve an overly terse error message.
* subversion/libsvn_fs_fs/tree.c
(fs_props_changed): Message fixed from r14473 also appears here.
Regards,
Karol Szkudlarek
Re: asking props
Posted by kf...@collab.net.
Karol Szkudlarek <ka...@mikronika.com.pl> writes:
> Now it's clear to me. Thanks. The message also appears in another file:
> libsvn_fs_fs/tree.c:1153.
>
> And similar two messages are located here:
>
> #: libsvn_fs_base/tree.c:3937 libsvn_fs_fs/tree.c:2593
> msgid "Asking contents changed in two different filesystems"
Thanks for noticing!
Could I persuade to you to post a patch for these? See HACKING and
http://subversion.tigris.org/mailing-list-guidelines.html#patches for
guidelines on sending patches.
If you don't have time for it, that's fine, just let us know.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: asking props
Posted by Karol Szkudlarek <ka...@mikronika.com.pl>.
kfogel@collab.net wrote:
> Karol Szkudlarek <ka...@mikronika.com.pl> writes:
>
>>Could anybody tell me what means the following svn
>>message:
>>
>>"Asking props changed in two different filesystems".
>>
>>What are the asking properties?
>
>
> It's a bit too terse. It means you're asking whether a property
> changed, but you've given two different filesystems for the
> comparison. In r14473, I changed it to
>
> "Cannot compare property value between two different filesystems"
>
Now it's clear to me. Thanks. The message also appears in another file:
libsvn_fs_fs/tree.c:1153.
And similar two messages are located here:
#: libsvn_fs_base/tree.c:3937 libsvn_fs_fs/tree.c:2593
msgid "Asking contents changed in two different filesystems"
Regards,
Karol
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: asking props
Posted by kf...@collab.net.
Karol Szkudlarek <ka...@mikronika.com.pl> writes:
> Could anybody tell me what means the following svn
> message:
>
> "Asking props changed in two different filesystems".
>
> What are the asking properties?
It's a bit too terse. It means you're asking whether a property
changed, but you've given two different filesystems for the
comparison. In r14473, I changed it to
"Cannot compare property value between two different filesystems"
Thanks,
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org