[GitHub] [airflow] francescomucio commented on a diff in pull request #25509: Possibility to document DAG with a separated markdown file

[GitBox <gi...@apache.org>]

francescomucio commented on code in PR #25509:
URL: https://github.com/apache/airflow/pull/25509#discussion_r937306706


##########
airflow/models/dag.py:
##########
@@ -522,7 +522,7 @@ def __init__(
         self.has_on_success_callback = self.on_success_callback is not None
         self.has_on_failure_callback = self.on_failure_callback is not None
 
-        self.doc_md = doc_md
+        self.doc_md = pathlib.Path(doc_md).read_text() if pathlib.Path(str(doc_md or '')).is_file() else doc_md

Review Comment:
   I was not able to find the logic used for .sql files in the SQL operators like the [here](https://github.com/apache/airflow/blob/main/airflow/providers/common/sql/operators/sql.py#L802).
   
   While testing I was not able to just pass "my_dag.py" but I had to pass a Path object, like you were mentioning, which is in my opinion more cumbersome and inconsistent (with what we do for .sql files)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org