You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/04/11 20:04:36 UTC
[GitHub] [orc] williamhyun opened a new pull request #681: ORC-783: Add a checkstyle rule to prevent trailing white spaces.
williamhyun opened a new pull request #681:
URL: https://github.com/apache/orc/pull/681
### What changes were proposed in this pull request?
This PR aims to add a checkstyle rule to prevent trailing white spaces.
### Why are the changes needed?
This will enforce the coding style before merging.
### How was this patch tested?
Pass the CIs or manually do the following.
```
$ cd java
$ mvn checkstyle:check -Panalyze
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #681: ORC-783: Add a checkstyle rule to prevent trailing white spaces.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #681:
URL: https://github.com/apache/orc/pull/681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #681: ORC-783: Add a checkstyle rule to prevent trailing white spaces.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #681:
URL: https://github.com/apache/orc/pull/681#discussion_r611298068
##########
File path: java/pom.xml
##########
@@ -275,6 +275,10 @@
</module>
<module name="NewlineAtEndOfFile">
</module>
+ <module name="RegexpSingleline">
+ <property name="format" value="\s+$"/>
+ <property name="message" value="No trailing white space allowed."/>
+ </module>
Review comment:
We need the following before `<checkstyleRules>`. Could you add that?
```xml
<configuration>
+ <sourceDirectories>
+ <directory>${basedir}/src/java</directory>
+ </sourceDirectories>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on a change in pull request #681: ORC-783: Add a checkstyle rule to prevent trailing white spaces.
Posted by GitBox <gi...@apache.org>.
williamhyun commented on a change in pull request #681:
URL: https://github.com/apache/orc/pull/681#discussion_r611327276
##########
File path: java/pom.xml
##########
@@ -275,6 +275,10 @@
</module>
<module name="NewlineAtEndOfFile">
</module>
+ <module name="RegexpSingleline">
+ <property name="format" value="\s+$"/>
+ <property name="message" value="No trailing white space allowed."/>
+ </module>
Review comment:
Thank you, I have updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org