You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/20 13:58:20 UTC
[GitHub] [airflow] ashishpatel0720 opened a new pull request #15454: #15416 - breeze should load local tmux configuration in 'breeze start-airflow'
ashishpatel0720 opened a new pull request #15454:
URL: https://github.com/apache/airflow/pull/15454
closes #15416
---
**Description**
Currently, when we run
`
breeze start-airflow
`
**breeze** doesn't load local tmux configuration file **.tmux.conf** and we get default tmux configuration inside the containers.
**PR effect**
After this change developers will be able to put their **.tmux.conf** file as **/files/airflow-breeze-config/.tmux.conf**
and Breeze will load local **tmux configuration** in to the containers and developers should be able to use their local configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #15454: Breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #15454:
URL: https://github.com/apache/airflow/pull/15454#issuecomment-823310240
> I guess, I have to update docs as well.
Indeed. Would be great to add it to BREEZE.rst, though we print it as output. I think we do not have the .env file mentioned there - so a small "customizing" environment chapter would be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15454: Breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15454:
URL: https://github.com/apache/airflow/pull/15454#issuecomment-823844731
[The Workflow run](https://github.com/apache/airflow/actions/runs/769806314) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15454: Breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15454:
URL: https://github.com/apache/airflow/pull/15454#issuecomment-823310789
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #15454: Breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15454:
URL: https://github.com/apache/airflow/pull/15454#discussion_r616785869
##########
File path: scripts/in_container/configure_environment.sh
##########
@@ -48,3 +49,20 @@ else
echo "In it to make breeze source the variables automatically for you"
echo
fi
+
+
+if [[ -d "${AIRFLOW_BREEZE_CONFIG_DIR}" && \
+ -f "${AIRFLOW_BREEZE_CONFIG_DIR}/${TMUX_CONF_FILE}" ]]; then
+ pushd "${AIRFLOW_BREEZE_CONFIG_DIR}" >/dev/null 2>&1 || exit 1
+ echo
+ echo "Using ${TMUX_CONF_FILE} from ${AIRFLOW_BREEZE_CONFIG_DIR}"
+ echo
+ # shellcheck disable=1090
+ cp "${AIRFLOW_BREEZE_CONFIG_DIR}/${TMUX_CONF_FILE}" ~
Review comment:
Would it be possible to `ln -s` instead so changes in the container can be kept?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15454: Breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15454:
URL: https://github.com/apache/airflow/pull/15454#issuecomment-823310240
> I guess, I have to update docs as well.
Indeed. Would be great to add it to BREEZE.rst, though we print it as output. I think we do not have the .env file mentioned there - so a small "cusromizing" environment chapter woudl be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #15454: Breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #15454:
URL: https://github.com/apache/airflow/pull/15454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pateash commented on a change in pull request #15454: Breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
pateash commented on a change in pull request #15454:
URL: https://github.com/apache/airflow/pull/15454#discussion_r617268866
##########
File path: scripts/in_container/configure_environment.sh
##########
@@ -48,3 +49,20 @@ else
echo "In it to make breeze source the variables automatically for you"
echo
fi
+
+
+if [[ -d "${AIRFLOW_BREEZE_CONFIG_DIR}" && \
+ -f "${AIRFLOW_BREEZE_CONFIG_DIR}/${TMUX_CONF_FILE}" ]]; then
+ pushd "${AIRFLOW_BREEZE_CONFIG_DIR}" >/dev/null 2>&1 || exit 1
+ echo
+ echo "Using ${TMUX_CONF_FILE} from ${AIRFLOW_BREEZE_CONFIG_DIR}"
+ echo
+ # shellcheck disable=1090
+ cp "${AIRFLOW_BREEZE_CONFIG_DIR}/${TMUX_CONF_FILE}" ~
Review comment:
Thanks for the suggestion @uranusjr.
changes has been done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15454: Breeze should load local tmux configuration in 'breeze start-airflow'
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15454:
URL: https://github.com/apache/airflow/pull/15454#discussion_r616877344
##########
File path: scripts/in_container/configure_environment.sh
##########
@@ -48,3 +49,20 @@ else
echo "In it to make breeze source the variables automatically for you"
echo
fi
+
+
+if [[ -d "${AIRFLOW_BREEZE_CONFIG_DIR}" && \
+ -f "${AIRFLOW_BREEZE_CONFIG_DIR}/${TMUX_CONF_FILE}" ]]; then
+ pushd "${AIRFLOW_BREEZE_CONFIG_DIR}" >/dev/null 2>&1 || exit 1
+ echo
+ echo "Using ${TMUX_CONF_FILE} from ${AIRFLOW_BREEZE_CONFIG_DIR}"
+ echo
+ # shellcheck disable=1090
+ cp "${AIRFLOW_BREEZE_CONFIG_DIR}/${TMUX_CONF_FILE}" ~
Review comment:
> Would it be possible to `ln -s` instead so changes in the container can be kept?
Good point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org