You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alexander Denissov <ad...@apache.org> on 2016/03/02 02:01:22 UTC
Review Request 44240: User should be able to remove HAWQ Standby via
UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44240/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Jayush Luniya, Lav Jain, Mahadev Konar, Matt, Newton Alex, Oleksandr Diachenko, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-15256
https://issues.apache.org/jira/browse/AMBARI-15256
Repository: ambari
Description
-------
Created a wizard to remove HAWQ Standby from the UI.
Diffs
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml b77eb34
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py 3309561
ambari-web/app/assets/test/tests.js a875656
ambari-web/app/controllers.js 8fa9e6b
ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step1_controller.js PRE-CREATION
ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step2_controller.js PRE-CREATION
ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step3_controller.js PRE-CREATION
ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/wizard_controller.js PRE-CREATION
ambari-web/app/controllers/main/admin/highAvailability_controller.js 0bdd09c
ambari-web/app/controllers/main/service/item.js e26a884
ambari-web/app/data/controller_route.js d254edb
ambari-web/app/messages.js d0c8840
ambari-web/app/models/host_component.js a3abd08
ambari-web/app/routes/main.js 419f845
ambari-web/app/routes/remove_hawq_standby_routes.js PRE-CREATION
ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step1.hbs PRE-CREATION
ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step2.hbs PRE-CREATION
ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step3.hbs PRE-CREATION
ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/wizard.hbs PRE-CREATION
ambari-web/app/utils/db.js 61acdee
ambari-web/app/views.js 9d606e9
ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/step1_view.js PRE-CREATION
ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/step2_view.js PRE-CREATION
ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/step3_view.js PRE-CREATION
ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/wizard_view.js PRE-CREATION
ambari-web/app/views/main/host/details/host_component_view.js d059498
ambari-web/app/views/main/service/item.js 020048b
ambari-web/test/controllers/main/admin/highAvailability/hawq/removeStandby/step2_controller_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/44240/diff/
Testing
-------
Manual testing in normal and secured environments.
ambari-web test cases pass:
24543 tests complete (26 seconds)
146 tests pending
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .idea/**
[INFO] Exclude: package.json
[INFO] Exclude: public/**
[INFO] Exclude: public-static/**
[INFO] Exclude: app/assets/**
[INFO] Exclude: vendor/**
[INFO] Exclude: node_modules/**
[INFO] Exclude: node/**
[INFO] Exclude: npm-debug.log
[INFO] 1362 resources included (use -debug for more details)
Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
Compiler warnings:
WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1362 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 42.757 s
[INFO] Finished at: 2016-03-01T16:08:54-08:00
Thanks,
Alexander Denissov
Re: Review Request 44240: User should be able to remove HAWQ Standby
via UI
Posted by Alexander Denissov <ad...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44240/
-----------------------------------------------------------
(Updated March 4, 2016, 7:27 p.m.)
Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Jayush Luniya, Lav Jain, Mahadev Konar, Matt, Newton Alex, Oleksandr Diachenko, Sumit Mohanty, and Yusaku Sako.
Changes
-------
added condition to check for undefined commandMap
Bugs: AMBARI-15256
https://issues.apache.org/jira/browse/AMBARI-15256
Repository: ambari
Description
-------
Created a wizard to remove HAWQ Standby from the UI.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml efcb867
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py 3309561
ambari-web/app/assets/test/tests.js 54013f8
ambari-web/app/controllers.js c9214f8
ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step1_controller.js PRE-CREATION
ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step2_controller.js PRE-CREATION
ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step3_controller.js PRE-CREATION
ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/wizard_controller.js PRE-CREATION
ambari-web/app/controllers/main/admin/highAvailability_controller.js 0bdd09c
ambari-web/app/controllers/main/service/item.js e26a884
ambari-web/app/data/controller_route.js d254edb
ambari-web/app/messages.js a12b729
ambari-web/app/models/host_component.js a3abd08
ambari-web/app/routes/main.js 419f845
ambari-web/app/routes/remove_hawq_standby_routes.js PRE-CREATION
ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step1.hbs PRE-CREATION
ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step2.hbs PRE-CREATION
ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step3.hbs PRE-CREATION
ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/wizard.hbs PRE-CREATION
ambari-web/app/utils/db.js 61acdee
ambari-web/app/views.js aa10456
ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/step1_view.js PRE-CREATION
ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/step2_view.js PRE-CREATION
ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/step3_view.js PRE-CREATION
ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/wizard_view.js PRE-CREATION
ambari-web/app/views/main/host/details/host_component_view.js d059498
ambari-web/app/views/main/service/item.js 020048b
ambari-web/test/controllers/main/admin/highAvailability/hawq/removeStandby/step2_controller_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/44240/diff/
Testing
-------
Manual testing in normal and secured environments.
ambari-web test cases pass:
24543 tests complete (26 seconds)
146 tests pending
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .idea/**
[INFO] Exclude: package.json
[INFO] Exclude: public/**
[INFO] Exclude: public-static/**
[INFO] Exclude: app/assets/**
[INFO] Exclude: vendor/**
[INFO] Exclude: node_modules/**
[INFO] Exclude: node/**
[INFO] Exclude: npm-debug.log
[INFO] 1362 resources included (use -debug for more details)
Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
Compiler warnings:
WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1362 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 42.757 s
[INFO] Finished at: 2016-03-01T16:08:54-08:00
Thanks,
Alexander Denissov
Re: Review Request 44240: User should be able to remove HAWQ Standby
via UI
Posted by Alexander Denissov <ad...@apache.org>.
> On March 2, 2016, 7:31 p.m., Matt wrote:
> > ambari-web/app/models/host_component.js, line 427
> > <https://reviews.apache.org/r/44240/diff/1/?file=1275925#file1275925line427>
> >
> > Does HAWQMASTER have to be in STARTED state?
yes, the underlying script expects it.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44240/#review121701
-----------------------------------------------------------
On March 2, 2016, 1:01 a.m., Alexander Denissov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44240/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 1:01 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Jayush Luniya, Lav Jain, Mahadev Konar, Matt, Newton Alex, Oleksandr Diachenko, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-15256
> https://issues.apache.org/jira/browse/AMBARI-15256
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created a wizard to remove HAWQ Standby from the UI.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml b77eb34
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py 3309561
> ambari-web/app/assets/test/tests.js a875656
> ambari-web/app/controllers.js 8fa9e6b
> ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step1_controller.js PRE-CREATION
> ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step2_controller.js PRE-CREATION
> ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step3_controller.js PRE-CREATION
> ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/wizard_controller.js PRE-CREATION
> ambari-web/app/controllers/main/admin/highAvailability_controller.js 0bdd09c
> ambari-web/app/controllers/main/service/item.js e26a884
> ambari-web/app/data/controller_route.js d254edb
> ambari-web/app/messages.js d0c8840
> ambari-web/app/models/host_component.js a3abd08
> ambari-web/app/routes/main.js 419f845
> ambari-web/app/routes/remove_hawq_standby_routes.js PRE-CREATION
> ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step1.hbs PRE-CREATION
> ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step2.hbs PRE-CREATION
> ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step3.hbs PRE-CREATION
> ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/wizard.hbs PRE-CREATION
> ambari-web/app/utils/db.js 61acdee
> ambari-web/app/views.js 9d606e9
> ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/step1_view.js PRE-CREATION
> ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/step2_view.js PRE-CREATION
> ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/step3_view.js PRE-CREATION
> ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/wizard_view.js PRE-CREATION
> ambari-web/app/views/main/host/details/host_component_view.js d059498
> ambari-web/app/views/main/service/item.js 020048b
> ambari-web/test/controllers/main/admin/highAvailability/hawq/removeStandby/step2_controller_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44240/diff/
>
>
> Testing
> -------
>
> Manual testing in normal and secured environments.
>
> ambari-web test cases pass:
>
> 24543 tests complete (26 seconds)
> 146 tests pending
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .idea/**
> [INFO] Exclude: package.json
> [INFO] Exclude: public/**
> [INFO] Exclude: public-static/**
> [INFO] Exclude: app/assets/**
> [INFO] Exclude: vendor/**
> [INFO] Exclude: node_modules/**
> [INFO] Exclude: node/**
> [INFO] Exclude: npm-debug.log
> [INFO] 1362 resources included (use -debug for more details)
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> Compiler warnings:
> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
> Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1362 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 42.757 s
> [INFO] Finished at: 2016-03-01T16:08:54-08:00
>
>
> Thanks,
>
> Alexander Denissov
>
>
Re: Review Request 44240: User should be able to remove HAWQ Standby
via UI
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44240/#review121701
-----------------------------------------------------------
Ship it!
ambari-web/app/models/host_component.js (line 427)
<https://reviews.apache.org/r/44240/#comment183477>
Does HAWQMASTER have to be in STARTED state?
- Matt
On March 1, 2016, 5:01 p.m., Alexander Denissov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44240/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 5:01 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Jayush Luniya, Lav Jain, Mahadev Konar, Matt, Newton Alex, Oleksandr Diachenko, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-15256
> https://issues.apache.org/jira/browse/AMBARI-15256
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created a wizard to remove HAWQ Standby from the UI.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml b77eb34
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py 3309561
> ambari-web/app/assets/test/tests.js a875656
> ambari-web/app/controllers.js 8fa9e6b
> ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step1_controller.js PRE-CREATION
> ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step2_controller.js PRE-CREATION
> ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step3_controller.js PRE-CREATION
> ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/wizard_controller.js PRE-CREATION
> ambari-web/app/controllers/main/admin/highAvailability_controller.js 0bdd09c
> ambari-web/app/controllers/main/service/item.js e26a884
> ambari-web/app/data/controller_route.js d254edb
> ambari-web/app/messages.js d0c8840
> ambari-web/app/models/host_component.js a3abd08
> ambari-web/app/routes/main.js 419f845
> ambari-web/app/routes/remove_hawq_standby_routes.js PRE-CREATION
> ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step1.hbs PRE-CREATION
> ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step2.hbs PRE-CREATION
> ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step3.hbs PRE-CREATION
> ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/wizard.hbs PRE-CREATION
> ambari-web/app/utils/db.js 61acdee
> ambari-web/app/views.js 9d606e9
> ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/step1_view.js PRE-CREATION
> ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/step2_view.js PRE-CREATION
> ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/step3_view.js PRE-CREATION
> ambari-web/app/views/main/admin/highAvailability/hawq/removeStandby/wizard_view.js PRE-CREATION
> ambari-web/app/views/main/host/details/host_component_view.js d059498
> ambari-web/app/views/main/service/item.js 020048b
> ambari-web/test/controllers/main/admin/highAvailability/hawq/removeStandby/step2_controller_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44240/diff/
>
>
> Testing
> -------
>
> Manual testing in normal and secured environments.
>
> ambari-web test cases pass:
>
> 24543 tests complete (26 seconds)
> 146 tests pending
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .idea/**
> [INFO] Exclude: package.json
> [INFO] Exclude: public/**
> [INFO] Exclude: public-static/**
> [INFO] Exclude: app/assets/**
> [INFO] Exclude: vendor/**
> [INFO] Exclude: node_modules/**
> [INFO] Exclude: node/**
> [INFO] Exclude: npm-debug.log
> [INFO] 1362 resources included (use -debug for more details)
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> Compiler warnings:
> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
> Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1362 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 42.757 s
> [INFO] Finished at: 2016-03-01T16:08:54-08:00
>
>
> Thanks,
>
> Alexander Denissov
>
>