[jira] [Commented] (NIFI-5223) Allow the usage of expression language for properties of RecordSetWriters

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513053#comment-16513053 ] 

ASF GitHub Bot commented on NIFI-5223:
--------------------------------------

Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2736#discussion_r195584322
  
    --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-service-api/src/main/java/org/apache/nifi/serialization/RecordSetWriterFactory.java ---
    @@ -76,5 +78,23 @@
          * @return a RecordSetWriter that can write record sets to an OutputStream
          * @throws IOException if unable to read from the given InputStream
          */
    -    RecordSetWriter createWriter(ComponentLog logger, RecordSchema schema, OutputStream out) throws SchemaNotFoundException, IOException;
    --- End diff --
    
    I agree with @pvillard31 on this point. We can't really change service interfaces with a very compelling reason otherwise we'll alienate third party developers.


> Allow the usage of expression language for properties of RecordSetWriters
> -------------------------------------------------------------------------
>
>                 Key: NIFI-5223
>                 URL: https://issues.apache.org/jira/browse/NIFI-5223
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Johannes Peter
>            Assignee: Johannes Peter
>            Priority: Major
>
> To allow the usage of expression language for properties of RecordSetWriters, the method createWriter of the interface RecordSetWriterFactory has to be enhanced by a parameter to provide a map containing variables of a FlowFile. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)