[GitHub] [iceberg] rdblue commented on pull request #1336: Fix schema name conflicts

[GitBox <gi...@apache.org>]

rdblue commented on pull request #1336:
URL: https://github.com/apache/iceberg/pull/1336#issuecomment-674163196


   Thanks for reviewing, @RussellSpitzer! I'll fix those issues.
   
   The short names are more obvious because they don't contain a hard-coded string that users need to know about. Consider the schema from the description, `locations list<struct<lat: double, long: double>>`. How does someone know to add `element` to reference `locations.element.lat`? I think it's more natural to allow referencing that field as `locations.lat`, as long as it doesn't conflict with other names.
   
   We've also already supported these names, so I think we should continue to support them. But adding the full names removes ambiguity introduced by the short names.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org