You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ponymail.apache.org by GitBox <gi...@apache.org> on 2022/04/04 10:49:02 UTC
[GitHub] [incubator-ponymail-foal] sbp opened a new pull request, #236: Use a default gravatar if one cannot be fetched
sbp opened a new pull request, #236:
URL: https://github.com/apache/incubator-ponymail-foal/pull/236
This PR makes the gravatar endpoint respond with a default PNG if no gravatar can be fetched remotely. The default PNG is just the same image that gravatar uses for its default profile image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ponymail-foal] Humbedooh commented on pull request #236: Use a default gravatar if one cannot be fetched
Posted by GitBox <gi...@apache.org>.
Humbedooh commented on PR #236:
URL: https://github.com/apache/incubator-ponymail-foal/pull/236#issuecomment-1091958706
I suppose I should clarify: do we want to wait (up to) 1 day in cases where avatar was not found, or do we want a shorter timeout here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ponymail-foal] sbp commented on pull request #236: Use a default gravatar if one cannot be fetched
Posted by GitBox <gi...@apache.org>.
sbp commented on PR #236:
URL: https://github.com/apache/incubator-ponymail-foal/pull/236#issuecomment-1087408913
I was thinking that if a gravatar later becomes available then it would be a good idea to reflect it in the UI as soon as possible, but also I don't understand why gravatar itself sometimes returns the default profile image and sometimes doesn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ponymail-foal] Humbedooh merged pull request #236: Use a default gravatar if one cannot be fetched
Posted by GitBox <gi...@apache.org>.
Humbedooh merged PR #236:
URL: https://github.com/apache/incubator-ponymail-foal/pull/236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ponymail-foal] Humbedooh commented on pull request #236: Use a default gravatar if one cannot be fetched
Posted by GitBox <gi...@apache.org>.
Humbedooh commented on PR #236:
URL: https://github.com/apache/incubator-ponymail-foal/pull/236#issuecomment-1087403894
Do we still want a 1 day cache in such cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ponymail-foal] sbp commented on pull request #236: Use a default gravatar if one cannot be fetched
Posted by GitBox <gi...@apache.org>.
sbp commented on PR #236:
URL: https://github.com/apache/incubator-ponymail-foal/pull/236#issuecomment-1101237412
If it's too short then I suppose it hits the server too much, but maybe an hour would be reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ponymail.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org