[GitHub] [airflow] benbenbang edited a comment on issue #9713: Looping issue using Hashicorp Vault

[GitBox <gi...@apache.org>]

benbenbang edited a comment on issue #9713:
URL: https://github.com/apache/airflow/issues/9713#issuecomment-670538903


   Hello @potiuk, @kaxil 
   
   I need some suggestions on the `default_var` has been set case ( not sure is it fixed in 2.x or not ?)
   
   if now we want to get variable by using Variable.get("X", default_var=123)
   This is how the flow goes in 1.10.x:
   ↓ You want to get Var X and you give a default_var 123
   ------- Airflow Variable ------
   ↓ Go to Vault backend
   ------- Vault -----------------
   ↓ Vault Cannot find X
   ↓ log print out and return None
    ------- Airflow Variable ------
   ↓ find default_var 123
   ↓ return 123
   
   Firstly, the log will be really confused. Since we cannot know will it return anything or not. Because in the Vault backend layer it doesn't know we did pass a default variable.
   
   Secondly, is there a better practice to do the retry? I mean seems like keep trying to get the value it makes some sense but should we have an option that allows us to set a cooldown timer?
   
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org