You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by xi...@apache.org on 2025/12/12 11:08:06 UTC
(pinot) branch master updated: Set merging segment creation time = max(creationTime) + 1 (#17356)
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 58e5c4afa8e Set merging segment creation time = max(creationTime) + 1 (#17356)
58e5c4afa8e is described below
commit 58e5c4afa8ef3f46f20c0a125469d40f5741ceab
Author: tarun11Mavani <35...@users.noreply.github.com>
AuthorDate: Fri Dec 12 16:37:59 2025 +0530
Set merging segment creation time = max(creationTime) + 1 (#17356)
* Set merging segment creation time = max(creationTime) + 1
---------
Co-authored-by: Xiang Fu <xi...@gmail.com>
---
.../tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.java b/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.java
index c3a898a799b..e5384ecca64 100644
--- a/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.java
+++ b/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.java
@@ -133,7 +133,9 @@ public class UpsertCompactMergeTaskExecutor extends BaseMultipleSegmentsConversi
}
// create new UploadedRealtimeSegment
- segmentProcessorConfigBuilder.setCustomCreationTime(maxCreationTimeOfMergingSegments);
+ // set the creation time to maxCreationTimeOfMergingSegments + 1 to ensure that all records in merging
+ // segments are replaced with new merged segment
+ segmentProcessorConfigBuilder.setCustomCreationTime(maxCreationTimeOfMergingSegments + 1);
segmentProcessorConfigBuilder.setSegmentNameGenerator(
new UploadedRealtimeSegmentNameGenerator(TableNameBuilder.extractRawTableName(tableNameWithType), partitionID,
System.currentTimeMillis(), MinionConstants.UpsertCompactMergeTask.MERGED_SEGMENT_NAME_PREFIX, null));
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org