You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/15 13:22:01 UTC
[GitHub] [dolphinscheduler] zhuangchong opened a new pull request, #12909: [Bug-12908][Worker]Fix execute shell task exception no dolphinscheduler_env.sh file execute permission
zhuangchong opened a new pull request, #12909:
URL: https://github.com/apache/dolphinscheduler/pull/12909
…ute permission
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
this pr closes: #12908
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #12909: [Bug-12908][Worker]Fix execute shell task exception no dolphinscheduler_env.sh file execute permission
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #12909:
URL: https://github.com/apache/dolphinscheduler/pull/12909#issuecomment-1315340011
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=12909)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12909&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12909&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhuangchong commented on a diff in pull request #12909: [Bug-12908][Worker]Fix execute shell task exception no dolphinscheduler_env.sh file execute permission
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on code in PR #12909:
URL: https://github.com/apache/dolphinscheduler/pull/12909#discussion_r1023408308
##########
dolphinscheduler-worker/src/main/bin/start.sh:
##########
@@ -21,7 +21,6 @@ DOLPHINSCHEDULER_HOME=${DOLPHINSCHEDULER_HOME:-$(cd $BIN_DIR/..; pwd)}
source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"
-chmod -R 700 ${DOLPHINSCHEDULER_HOME}/conf
Review Comment:
There is account password information in the application.yaml file in the conf directory, so it is not recommended to set the permission to 755.
If it is set to `chmod -R 755 ${DOLPHINSCHEDULER_HOME}/conf/dolphinscheduler_env.sh`, when the conf folder does not have other user execution permissions, it will still report that the dolphinscheduler_env.sh file permissions are insufficient.
Do you have any good suggestions for only setting dolphinscheduler_env.sh file permissions to 755 and other file permissions to 700?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #12909: [Bug-12908][Worker]Fix execute shell task exception no dolphinscheduler_env.sh file execute permission
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #12909:
URL: https://github.com/apache/dolphinscheduler/pull/12909#issuecomment-1315331052
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=12909)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12909&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12909&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on a diff in pull request #12909: [Bug-12908][Worker]Fix execute shell task exception no dolphinscheduler_env.sh file execute permission
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on code in PR #12909:
URL: https://github.com/apache/dolphinscheduler/pull/12909#discussion_r1022811480
##########
dolphinscheduler-worker/src/main/bin/start.sh:
##########
@@ -21,7 +21,6 @@ DOLPHINSCHEDULER_HOME=${DOLPHINSCHEDULER_HOME:-$(cd $BIN_DIR/..; pwd)}
source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"
-chmod -R 700 ${DOLPHINSCHEDULER_HOME}/conf
Review Comment:
chould we change to `755`? WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on a diff in pull request #12909: [Bug-12908][Worker]Fix execute shell task exception no dolphinscheduler_env.sh file execute permission
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on code in PR #12909:
URL: https://github.com/apache/dolphinscheduler/pull/12909#discussion_r1023417228
##########
dolphinscheduler-worker/src/main/bin/start.sh:
##########
@@ -21,7 +21,6 @@ DOLPHINSCHEDULER_HOME=${DOLPHINSCHEDULER_HOME:-$(cd $BIN_DIR/..; pwd)}
source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"
-chmod -R 700 ${DOLPHINSCHEDULER_HOME}/conf
Review Comment:
> There is account password information in the application.yaml file in the conf directory, so it is not recommended to set the permission to 755.
>
> If it is set to `chmod -R 755 ${DOLPHINSCHEDULER_HOME}/conf/dolphinscheduler_env.sh`, when the conf folder does not have other user execution permissions, it will still report that the dolphinscheduler_env.sh file permissions are insufficient.
>
> Do you have any good suggestions for only setting dolphinscheduler_env.sh file permissions to 755 and other file permissions to 700?
IMHO, I have the following two ideas：
1. Just keep only one `dolphinscheduler_env.sh` in bin/env/dolphinscheduler_env.sh, all services no longer keep a separate copy of the file. Becasue all these files are same. So we just need chmod -R 755 `bin/env/dolphinscheduler_env.sh`
2. All tmp execution path source a source file in other disk path is not a good idea. May can copy it to execution path and clear it after task finished. This ensures that all files needed for the task to run are stored in the temporary execution directory. WDYT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhuangchong merged pull request #12909: [Bug-12908][Worker]Fix execute shell task exception no dolphinscheduler_env.sh file execute permission
Posted by GitBox <gi...@apache.org>.
zhuangchong merged PR #12909:
URL: https://github.com/apache/dolphinscheduler/pull/12909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #12909: [Bug-12908][Worker]Fix execute shell task exception no dolphinscheduler_env.sh file execute permission
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #12909:
URL: https://github.com/apache/dolphinscheduler/pull/12909#discussion_r1024673806
##########
dolphinscheduler-worker/src/main/bin/start.sh:
##########
@@ -21,7 +21,6 @@ DOLPHINSCHEDULER_HOME=${DOLPHINSCHEDULER_HOME:-$(cd $BIN_DIR/..; pwd)}
source "$DOLPHINSCHEDULER_HOME/conf/dolphinscheduler_env.sh"
-chmod -R 700 ${DOLPHINSCHEDULER_HOME}/conf
Review Comment:
Remove `chmod -R 700 ${DOLPHINSCHEDULER_HOME}/conf` is ok for me.
If fact, `${DOLPHINSCHEDULER_HOME}/conf/dolphinscheduler_env.sh` is the default env faile will be sourced by task, we can change this in common.properties `dolphinscheduler.env.path`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org