You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "divijvaidya (via GitHub)" <gi...@apache.org> on 2023/05/05 09:11:17 UTC

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13676: MINOR: Capture build scans on ge.apache.org to benefit from deep build insights

divijvaidya commented on code in PR #13676:
URL: https://github.com/apache/kafka/pull/13676#discussion_r1185859941


##########
settings.gradle:
##########
@@ -13,6 +13,38 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+plugins {
+    id 'com.gradle.enterprise' version '3.13.1'

Review Comment:
   Would these plugins be loaded for local builds as well (I understand that they won't be used based on code below)?



##########
settings.gradle:
##########
@@ -13,6 +13,38 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+plugins {
+    id 'com.gradle.enterprise' version '3.13.1'
+    id 'com.gradle.common-custom-user-data-gradle-plugin' version '1.10'
+}
+
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+    server = "https://ge.apache.org"
+    buildScan {
+        capture { taskInputFiles = true }
+        uploadInBackground = !isCI
+        publishAlways()
+        publishIfAuthenticated()
+        obfuscation {
+            ipAddresses { addresses -> addresses.collect { address -> "0.0.0.0"} }

Review Comment:
   Please add a comment here so that future maintainers can understand the motivation of this line.
   
   Something like, "We are obfuscating ip address of the CI hosts here. HostNames will still be available in the scans to detect any Host specific slowness / flaky errors"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org