[GitHub] graceguo-supercat commented on a change in pull request #5360: [dashboard] Fix save issue at Force_V2_Edit mode

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #5360: [dashboard] Fix save issue at Force_V2_Edit mode
URL: https://github.com/apache/incubator-superset/pull/5360#discussion_r200800366
 
 

 ##########
 File path: superset/assets/src/dashboard/deprecated/v1/components/Controls.jsx
 ##########
 @@ -144,6 +144,7 @@ class Controls extends React.PureComponent {
             }
           />
           {dashboard.dash_save_perm &&
+            dashboard.force_v2_edit &&
 
 Review comment:
   force_v2_edit  = CAN_FALLBACK_TO_DASH_V1_EDIT_MODE is false

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org