You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2018/01/13 03:14:06 UTC
Review Request 65148: HIVE-18452 work around HADOOP-15171
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65148/
-----------------------------------------------------------
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0564b50276
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 1e0eccfa34
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 627e617d91
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java df536ead1c
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java 203ef69cf6
Diff: https://reviews.apache.org/r/65148/diff/1/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 65148: HIVE-18452 work around HADOOP-15171
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65148/#review195495
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java
Lines 1919 (patched)
<https://reviews.apache.org/r/65148/#comment274694>
this should be removed
- Sergey Shelukhin
On Jan. 13, 2018, 3:19 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65148/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2018, 3:19 a.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0564b50276
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 1e0eccfa34
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 627e617d91
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java df536ead1c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java 203ef69cf6
>
>
> Diff: https://reviews.apache.org/r/65148/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65148: HIVE-18452 work around HADOOP-15171
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Jan. 16, 2018, 9:40 p.m., Ashutosh Chauhan wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> > Lines 1381 (patched)
> > <https://reviews.apache.org/r/65148/diff/3/?file=1939897#file1939897line1381>
> >
> > Default should be false until Hadoop bug is fixed, since otherwise we will hit bug in default config.
The bug is not related to the codec pool, it happens with pool off. I added this because we are adding new untested (practiclaly speaking) functionality with the pool, so it's good to have an option to disable it
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65148/#review195504
-----------------------------------------------------------
On Jan. 13, 2018, 3:19 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65148/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2018, 3:19 a.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0564b50276
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 1e0eccfa34
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 627e617d91
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java df536ead1c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java 203ef69cf6
>
>
> Diff: https://reviews.apache.org/r/65148/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65148: HIVE-18452 work around HADOOP-15171
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65148/#review195504
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 1381 (patched)
<https://reviews.apache.org/r/65148/#comment274698>
Default should be false until Hadoop bug is fixed, since otherwise we will hit bug in default config.
- Ashutosh Chauhan
On Jan. 13, 2018, 3:19 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65148/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2018, 3:19 a.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0564b50276
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 1e0eccfa34
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 627e617d91
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java df536ead1c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java 203ef69cf6
>
>
> Diff: https://reviews.apache.org/r/65148/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65148: HIVE-18452 work around HADOOP-15171
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65148/
-----------------------------------------------------------
(Updated Jan. 13, 2018, 3:19 a.m.)
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0564b50276
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 1e0eccfa34
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 627e617d91
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java df536ead1c
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java 203ef69cf6
Diff: https://reviews.apache.org/r/65148/diff/3/
Changes: https://reviews.apache.org/r/65148/diff/2-3/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 65148: HIVE-18452 work around HADOOP-15171
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65148/
-----------------------------------------------------------
(Updated Jan. 13, 2018, 3:17 a.m.)
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0564b50276
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 1e0eccfa34
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 627e617d91
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java df536ead1c
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java 203ef69cf6
Diff: https://reviews.apache.org/r/65148/diff/2/
Changes: https://reviews.apache.org/r/65148/diff/1-2/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 65148: HIVE-18452 work around HADOOP-15171
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65148/
-----------------------------------------------------------
(Updated Jan. 13, 2018, 3:14 a.m.)
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0564b50276
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 1e0eccfa34
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 627e617d91
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java df536ead1c
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java 203ef69cf6
Diff: https://reviews.apache.org/r/65148/diff/1/
Testing
-------
Thanks,
Sergey Shelukhin