You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dwmclary <gi...@git.apache.org> on 2015/03/17 09:12:01 UTC
[GitHub] spark pull request: Spark 6359 expose imain binding
GitHub user dwmclary opened a pull request:
https://github.com/apache/spark/pull/5066
Spark 6359 expose imain binding
As per the associated JIRA ticket: in 1.2, some projects (e.g. Apache Zeppelin) rely on the ILoop exposing its IMain object for the purpose of binding UI variables to the underlying repl. The privatization of these methods in 1.3.0 breaks projects which rely on this. This PR exposes the two methods Zeppelin relies on (bindValue and classServerUri).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dwmclary/spark SPARK-6359-expose-IMain-binding
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5066.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5066
----
commit bea568c1859131a0a5d6747be4598591090e173b
Author: Dan McClary <da...@gmail.com>
Date: 2015-03-16T16:56:14Z
adding developer hooks into iloop for bind
commit 76517232c260cdf651bab40c629f21ccff8b91cc
Author: Dan McClary <da...@gmail.com>
Date: 2015-03-17T08:08:01Z
added public methods, test in ReplSuite
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Spark 6359 expose imain binding
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5066#issuecomment-96768841
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Spark 6359 expose imain binding
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5066#issuecomment-82195636
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Spark 6359 expose imain binding
Posted by dwmclary <gi...@git.apache.org>.
Github user dwmclary closed the pull request at:
https://github.com/apache/spark/pull/5066
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org