[GitHub] [pulsar] codelipenghui commented on a change in pull request #8635: Fix the pulsar sql can not query the last message issue

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #8635:
URL: https://github.com/apache/pulsar/pull/8635#discussion_r527309403



##########
File path: conf/broker.conf
##########
@@ -774,6 +774,9 @@ bookkeeperDiskWeightBasedPlacementEnabled=false
 # A value of '0' disables sending any explicit LACs. Default is 0.
 bookkeeperExplicitLacIntervalInMills=0
 
+  # Use older Bookkeeper wire protocol with bookie
+bookkeeperUseV2WireProtocol=true

Review comment:
       I think we already have this config in the broker.conf https://github.com/apache/pulsar/blob/master/conf/broker.conf#L680

##########
File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarConnectorConfig.java
##########
@@ -72,6 +72,8 @@
     private int bookkeeperThrottleValue = 0;
     private int bookkeeperNumIOThreads = 2 * Runtime.getRuntime().availableProcessors();
     private int bookkeeperNumWorkerThreads = Runtime.getRuntime().availableProcessors();
+    private boolean useV2Protocol = true;

Review comment:
       ```suggestion
       private boolean bookkeeperUseV2Protocol = true;
   ```

##########
File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarConnectorConfig.java
##########
@@ -72,6 +72,8 @@
     private int bookkeeperThrottleValue = 0;
     private int bookkeeperNumIOThreads = 2 * Runtime.getRuntime().availableProcessors();
     private int bookkeeperNumWorkerThreads = Runtime.getRuntime().availableProcessors();
+    private boolean useV2Protocol = true;
+    private int explicitInterval = 0;

Review comment:
       ```suggestion
       private int bookkeeperExplicitInterval = 0;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org