[GitHub] [solr] dsmiley commented on pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

["dsmiley (via GitHub)" <gi...@apache.org>]

dsmiley commented on PR #1218:
URL: https://github.com/apache/solr/pull/1218#issuecomment-1402176092

   > I think I am slowly starting to grok what this is all about... Let me see if I can state the value.... "Using a TestRule simplifies the setup of a test by abstracting away a lot of the Solr environment setup into the specific TestRule you choose. This means choosing the right TestRule to use is an important decision when writing a test, to make sure you have the right abstraction of Solr you need"...???
   
   Yes!  One could argue we have similar things already -- EmbeddedSolrServer, JettySolrRunner, MiniSolrCloudCluster, and corresponding base classes.  But the look & feel is very different.  So the aim standardizes the approach between them so that using any of these requires little new knowledge.  This isn't evident in this PR as it's just one rule but there are more to create.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org