You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/05/15 22:55:45 UTC
[jira] Created: (CASSANDRA-184) intermittent test failure
intermittent test failure
-------------------------
Key: CASSANDRA-184
URL: https://issues.apache.org/jira/browse/CASSANDRA-184
Project: Cassandra
Issue Type: Bug
Affects Versions: 0.3
Reporter: Jonathan Ellis
[junit] junit.framework.AssertionFailedError
[junit] at org.apache.cassandra.io.SSTable.delete(SSTable.java:223)
[junit] at org.apache.cassandra.db.ColumnFamilyStore.doFileCompaction(ColumnFamilyStore.java:1454)
[junit] at org.apache.cassandra.db.ColumnFamilyStore.doCompaction(ColumnFamilyStore.java:896)
[junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction(OneCompactionTest.java:47)
[junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction2(OneCompactionTest.java:60)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-184) intermittent OneCompactionTest
failure
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-184:
-------------------------------------
Attachment: 184-0.3.patch
OneCompactionTest is failing occasionally because 500 keys per CFS is actually triggering anautomatic compaction (since test flush threshold is only 20) and we were doing a non-threadsafe doCompaction for convenience: the failure occurs when our manual compaction begins mid-run of an automatic one, and the automatic deletesthe original sstable file first. Fix by (a) dropping the number of keys so that OneCompactionTest lives up to its name (more are tested in "CompactionsTest") and (b) making the compactions call threadsafe by refactoring to allow a threshold parameter to MCM.submit.
> intermittent OneCompactionTest failure
> --------------------------------------
>
> Key: CASSANDRA-184
> URL: https://issues.apache.org/jira/browse/CASSANDRA-184
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Jonathan Ellis
> Attachments: 184-0.3.patch, 184-trunk.patch
>
>
> [junit] junit.framework.AssertionFailedError
> [junit] at org.apache.cassandra.io.SSTable.delete(SSTable.java:223)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doFileCompaction(ColumnFamilyStore.java:1454)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doCompaction(ColumnFamilyStore.java:896)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction(OneCompactionTest.java:47)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction2(OneCompactionTest.java:60)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-184) intermittent OneCompactionTest
failure
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710455#action_12710455 ]
Jonathan Ellis commented on CASSANDRA-184:
------------------------------------------
only one compaction can be in progress at a time, but flushes and compactions can happen concurrently (different executors) so a thread flushing CF A can schedule A for a compaction (i.e. submit the op on the MCM) even if A is currently being compacted. the comment is explaining that when the MCM gets to that redundant compact the impact will be minimal.
> intermittent OneCompactionTest failure
> --------------------------------------
>
> Key: CASSANDRA-184
> URL: https://issues.apache.org/jira/browse/CASSANDRA-184
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Jonathan Ellis
> Attachments: 184-0.3.patch, 184-trunk.patch
>
>
> [junit] junit.framework.AssertionFailedError
> [junit] at org.apache.cassandra.io.SSTable.delete(SSTable.java:223)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doFileCompaction(ColumnFamilyStore.java:1454)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doCompaction(ColumnFamilyStore.java:896)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction(OneCompactionTest.java:47)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction2(OneCompactionTest.java:60)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-184) intermittent OneCompactionTest
failure
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-184:
-------------------------------------
Summary: intermittent OneCompactionTest failure (was: intermittent test failure)
> intermittent OneCompactionTest failure
> --------------------------------------
>
> Key: CASSANDRA-184
> URL: https://issues.apache.org/jira/browse/CASSANDRA-184
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Jonathan Ellis
>
> [junit] junit.framework.AssertionFailedError
> [junit] at org.apache.cassandra.io.SSTable.delete(SSTable.java:223)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doFileCompaction(ColumnFamilyStore.java:1454)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doCompaction(ColumnFamilyStore.java:896)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction(OneCompactionTest.java:47)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction2(OneCompactionTest.java:60)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-184) intermittent OneCompactionTest
failure
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711616#action_12711616 ]
Hudson commented on CASSANDRA-184:
----------------------------------
Integrated in Cassandra #83 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/83/])
more cleanup of compaction code.
patch by jbellis; reviewed by Jun Rao for
> intermittent OneCompactionTest failure
> --------------------------------------
>
> Key: CASSANDRA-184
> URL: https://issues.apache.org/jira/browse/CASSANDRA-184
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3, 0.4
>
> Attachments: 184-0.3.patch, 184-trunk.patch
>
>
> [junit] junit.framework.AssertionFailedError
> [junit] at org.apache.cassandra.io.SSTable.delete(SSTable.java:223)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doFileCompaction(ColumnFamilyStore.java:1454)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doCompaction(ColumnFamilyStore.java:896)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction(OneCompactionTest.java:47)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction2(OneCompactionTest.java:60)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-184) intermittent OneCompactionTest
failure
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-184:
-------------------------------------
Attachment: 184-trunk.patch
patch for trunk that applies on top of the one for 0.3. additional cleanup.
> intermittent OneCompactionTest failure
> --------------------------------------
>
> Key: CASSANDRA-184
> URL: https://issues.apache.org/jira/browse/CASSANDRA-184
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Jonathan Ellis
> Attachments: 184-0.3.patch, 184-trunk.patch
>
>
> [junit] junit.framework.AssertionFailedError
> [junit] at org.apache.cassandra.io.SSTable.delete(SSTable.java:223)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doFileCompaction(ColumnFamilyStore.java:1454)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doCompaction(ColumnFamilyStore.java:896)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction(OneCompactionTest.java:47)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction2(OneCompactionTest.java:60)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-184) intermittent OneCompactionTest
failure
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-184:
-------------------------------------
Component/s: Core
> intermittent OneCompactionTest failure
> --------------------------------------
>
> Key: CASSANDRA-184
> URL: https://issues.apache.org/jira/browse/CASSANDRA-184
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.3
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 184-0.3.patch, 184-trunk.patch
>
>
> [junit] junit.framework.AssertionFailedError
> [junit] at org.apache.cassandra.io.SSTable.delete(SSTable.java:223)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doFileCompaction(ColumnFamilyStore.java:1454)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doCompaction(ColumnFamilyStore.java:896)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction(OneCompactionTest.java:47)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction2(OneCompactionTest.java:60)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-184) intermittent OneCompactionTest
failure
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-184.
--------------------------------------
Resolution: Fixed
Fix Version/s: 0.4
0.3
Assignee: Jonathan Ellis
guess we are good here. committed.
> intermittent OneCompactionTest failure
> --------------------------------------
>
> Key: CASSANDRA-184
> URL: https://issues.apache.org/jira/browse/CASSANDRA-184
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3, 0.4
>
> Attachments: 184-0.3.patch, 184-trunk.patch
>
>
> [junit] junit.framework.AssertionFailedError
> [junit] at org.apache.cassandra.io.SSTable.delete(SSTable.java:223)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doFileCompaction(ColumnFamilyStore.java:1454)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doCompaction(ColumnFamilyStore.java:896)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction(OneCompactionTest.java:47)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction2(OneCompactionTest.java:60)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-184) intermittent OneCompactionTest
failure
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710445#action_12710445 ]
Jun Rao commented on CASSANDRA-184:
-----------------------------------
The patch looks fine to me.
The following comment in CFS.storeLocation() confuses me:
/* it's ok if compaction gets submitted multiple times while one is already in process.
worst that happens is, compactor will count the sstable files and decide there are
not enough to bother with. */
With this patch, there can't be mutiple ongoing compactions, right?
> intermittent OneCompactionTest failure
> --------------------------------------
>
> Key: CASSANDRA-184
> URL: https://issues.apache.org/jira/browse/CASSANDRA-184
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.3
> Reporter: Jonathan Ellis
> Attachments: 184-0.3.patch, 184-trunk.patch
>
>
> [junit] junit.framework.AssertionFailedError
> [junit] at org.apache.cassandra.io.SSTable.delete(SSTable.java:223)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doFileCompaction(ColumnFamilyStore.java:1454)
> [junit] at org.apache.cassandra.db.ColumnFamilyStore.doCompaction(ColumnFamilyStore.java:896)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction(OneCompactionTest.java:47)
> [junit] at org.apache.cassandra.db.OneCompactionTest.testCompaction2(OneCompactionTest.java:60)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.