You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/08 03:19:08 UTC
[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request
#3895: Insert clause sharding column null text judgement
SteNicholas opened a new pull request #3895: Insert clause sharding column null text judgement
URL: https://github.com/apache/incubator-shardingsphere/pull/3895
Fixes #3884.
Method `createShardingCondition` of `InsertClauseShardingConditionEngine` couldn't handle the situation that `ExpressionSegment` of null value in literal insert SQL is `CommonExpressionSegment`, and text of `CommonExpressionSegment` is "null".
Changes proposed in this pull request:
- Method `createShardingCondition` of InsertClauseShardingConditionEngine modify null expression judgement with "null" text.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3895:
Insert clause sharding column null text judgement
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #3895: Insert clause sharding column null text judgement
URL: https://github.com/apache/incubator-shardingsphere/pull/3895#issuecomment-571882502
## Pull Request Test Coverage Report for [Build 1282](https://coveralls.io/builds/27971721)
* **0** of **1** **(0.0%)** changed or added relevant line in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **65.705%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/router/sharding/condition/ExpressionConditionUtils.java](https://coveralls.io/builds/27971721/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Froute%2Frouter%2Fsharding%2Fcondition%2FExpressionConditionUtils.java#L46) | 0 | 1 | 0.0%
<!-- | **Total:** | **0** | **1** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/27971721) |
| :-- | --: |
| Change from base [Build 657](https://coveralls.io/builds/27970387): | 0.0% |
| Covered Lines: | 10723 |
| Relevant Lines: | 16320 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] nancyzrh commented on issue #3895:
Insert clause sharding column null text judgement
Posted by GitBox <gi...@apache.org>.
nancyzrh commented on issue #3895: Insert clause sharding column null text judgement
URL: https://github.com/apache/incubator-shardingsphere/pull/3895#issuecomment-571874844
/run ci
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion merged pull request #3895:
Insert clause sharding column null text judgement
Posted by GitBox <gi...@apache.org>.
KomachiSion merged pull request #3895: Insert clause sharding column null text judgement
URL: https://github.com/apache/incubator-shardingsphere/pull/3895
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services