You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uniffle.apache.org by zu...@apache.org on 2025/07/23 09:30:47 UTC

(uniffle) branch master updated: [#2533] fix(client): NPE on rendering spark UI tab (#2552)

This is an automated email from the ASF dual-hosted git repository.

zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 10df07dc8 [#2533] fix(client): NPE on rendering spark UI tab (#2552)
10df07dc8 is described below

commit 10df07dc812c0eea93a8d0e275538694254f4bef
Author: Zhen Wang <64...@qq.com>
AuthorDate: Wed Jul 23 17:30:43 2025 +0800

    [#2533] fix(client): NPE on rendering spark UI tab (#2552)
    
    ### What changes were proposed in this pull request?
    
    Fix NPE on rendering spark UI tab
    
    closes #2533
    
    ### Why are the changes needed?
    
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    minor fix
---
 .../extension/src/main/scala/org/apache/spark/UniffleStatusStore.scala  | 2 +-
 .../extension/src/main/scala/org/apache/spark/ui/ShufflePage.scala      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/client-spark/extension/src/main/scala/org/apache/spark/UniffleStatusStore.scala b/client-spark/extension/src/main/scala/org/apache/spark/UniffleStatusStore.scala
index e7aa3240f..931a1ce53 100644
--- a/client-spark/extension/src/main/scala/org/apache/spark/UniffleStatusStore.scala
+++ b/client-spark/extension/src/main/scala/org/apache/spark/UniffleStatusStore.scala
@@ -54,7 +54,7 @@ class UniffleStatusStore(store: KVStore) {
     try {
       store.read(kClass, kClass.getName)
     } catch {
-      case _: NoSuchElementException => AggregatedShuffleWriteTimesUIData(null)
+      case _: NoSuchElementException => AggregatedShuffleWriteTimesUIData(new ShuffleWriteTimes())
     }
   }
 
diff --git a/client-spark/extension/src/main/scala/org/apache/spark/ui/ShufflePage.scala b/client-spark/extension/src/main/scala/org/apache/spark/ui/ShufflePage.scala
index 4efa5d151..e4b32bdb8 100644
--- a/client-spark/extension/src/main/scala/org/apache/spark/ui/ShufflePage.scala
+++ b/client-spark/extension/src/main/scala/org/apache/spark/ui/ShufflePage.scala
@@ -147,7 +147,7 @@ class ShufflePage(parent: ShuffleTab) extends WebUIPage("") with Logging {
     )
 
     // render shuffle write times
-    val writeTimes = Option(runtimeStatusStore.shuffleWriteTimes()).map(_.times).getOrElse(new ShuffleWriteTimes())
+    val writeTimes = runtimeStatusStore.shuffleWriteTimes().times
     val total = if (writeTimes.getTotal <= 0) -1 else writeTimes.getTotal
     val writeTimesUI = UIUtils.listingTable(
       Seq("Total Time", "Wait Finish Time", "Copy Time", "Serialize Time", "Compress Time", "Sort Time", "Require Memory Time"),