You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2021/10/27 16:11:32 UTC
[Impala-ASF-CR] IMPALA-10899: buildall.sh -release and debug -codecoverage doesn't work as expected
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17982
Change subject: IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
......................................................................
IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
Until this patch buildall.sh -release_and_debug -codecoverage didn't
do a coverage build at all. It only did a release build, then a debug
build.
With this patch the above command creates a release+coverage build,
then a debug+coverage build. After each build it saves the .gcno
files to a directory in $IMPALA_HOME (gcov_release and gcov_debug).
These .gcno files are needed to generate code coverage reports later.
Testing:
* manually tested by invoking buildall.sh -release_and_debug \
-codecoverage
and
buildall.sh -release -codecoverage
Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
---
M buildall.sh
1 file changed, 33 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/17982/1
--
To view, visit http://gerrit.cloudera.org:8080/17982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10899: buildall.sh -release and debug -codecoverage doesn't work as expected
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17982 )
Change subject: IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17982/2/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/17982/2/buildall.sh@464
PS2, Line 464: build_type=$1
: gcov_prefix
Both of these variables should be declared "local" (see L489). The name "build_type" may clash with the usage above.
--
To view, visit http://gerrit.cloudera.org:8080/17982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Oct 2021 19:31:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10899: buildall.sh -release and debug -codecoverage doesn't work as expected
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17982 )
Change subject: IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
......................................................................
IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
Until this patch buildall.sh -release_and_debug -codecoverage didn't
do a coverage build at all. It only did a release build, then a debug
build.
With this patch the above command creates a release+coverage build,
then a debug+coverage build. After each build it saves the .gcno
files to a directory in $IMPALA_HOME (gcov_release and gcov_debug).
These .gcno files are needed to generate code coverage reports later.
Testing:
* manually tested by invoking buildall.sh -release_and_debug \
-codecoverage
and
buildall.sh -release -codecoverage
Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
---
M buildall.sh
1 file changed, 33 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/17982/2
--
To view, visit http://gerrit.cloudera.org:8080/17982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10899: buildall.sh -release and debug -codecoverage doesn't work as expected
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17982 )
Change subject: IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9678/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Oct 2021 16:34:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10899: buildall.sh -release and debug -codecoverage doesn't work as expected
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17982 )
Change subject: IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17982/2/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/17982/2/buildall.sh@464
PS2, Line 464: local build_type=$1
: local gcov_
> Both of these variables should be declared "local" (see L489). The name "bu
Thanks for catching this. Done.
--
To view, visit http://gerrit.cloudera.org:8080/17982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Oct 2021 10:36:00 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10899: buildall.sh -release and debug -codecoverage doesn't work as expected
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17982 )
Change subject: IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7578/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Oct 2021 12:45:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10899: buildall.sh -release and debug -codecoverage doesn't work as expected
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17982
to look at the new patch set (#3).
Change subject: IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
......................................................................
IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
Until this patch buildall.sh -release_and_debug -codecoverage didn't
do a coverage build at all. It only did a release build, then a debug
build.
With this patch the above command creates a release+coverage build,
then a debug+coverage build. After each build it saves the .gcno
files to a directory in $IMPALA_HOME (gcov_release and gcov_debug).
These .gcno files are needed to generate code coverage reports later.
Testing:
* manually tested by invoking buildall.sh -release_and_debug \
-codecoverage
and
buildall.sh -release -codecoverage
Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
---
M buildall.sh
1 file changed, 33 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/17982/3
--
To view, visit http://gerrit.cloudera.org:8080/17982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-10899: buildall.sh -release and debug -codecoverage doesn't work as expected
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17982 )
Change subject: IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
......................................................................
Patch Set 3: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/17982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Oct 2021 10:57:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10899: buildall.sh -release and debug -codecoverage doesn't work as expected
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17982 )
Change subject: IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9679/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Oct 2021 16:33:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10899: buildall.sh -release and debug -codecoverage doesn't work as expected
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17982 )
Change subject: IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Oct 2021 12:45:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10899: buildall.sh -release and debug -codecoverage doesn't work as expected
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17982 )
Change subject: IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Oct 2021 19:00:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10899: buildall.sh -release and debug -codecoverage doesn't work as expected
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17982 )
Change subject: IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
......................................................................
IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
Until this patch buildall.sh -release_and_debug -codecoverage didn't
do a coverage build at all. It only did a release build, then a debug
build.
With this patch the above command creates a release+coverage build,
then a debug+coverage build. After each build it saves the .gcno
files to a directory in $IMPALA_HOME (gcov_release and gcov_debug).
These .gcno files are needed to generate code coverage reports later.
Testing:
* manually tested by invoking buildall.sh -release_and_debug \
-codecoverage
and
buildall.sh -release -codecoverage
Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Reviewed-on: http://gerrit.cloudera.org:8080/17982
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M buildall.sh
1 file changed, 33 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10899: buildall.sh -release and debug -codecoverage doesn't work as expected
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17982 )
Change subject: IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9688/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Oct 2021 10:57:03 +0000
Gerrit-HasComments: No