You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/02 09:57:05 UTC

[GitHub] [arrow-rs] waitingkuo commented on a diff in pull request #3000: Round instead of Truncate while casting float to decimal

waitingkuo commented on code in PR #3000:
URL: https://github.com/apache/arrow-rs/pull/3000#discussion_r1011494924


##########
arrow/src/compute/kernels/cast.rs:
##########
@@ -3192,8 +3194,8 @@ mod tests {
             Some(2.2),
             Some(4.4),
             None,
-            Some(1.123_456_7),
-            Some(1.123_456_7),
+            Some(1.123_456_4), // round down
+            Some(1.123_456_7), // round up

Review Comment:
   i change the test cases to 
   1. round down
   2. round up



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org