You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/18 10:29:24 UTC
[GitHub] [superset] Germandrummer92 opened a new pull request, #22770: Build multiple python version images
Germandrummer92 opened a new pull request, #22770:
URL: https://github.com/apache/superset/pull/22770
### SUMMARY
We would like to use python3.9/3.10 in our custom configuration code to have some nice-to-have features. I don't really see a reason why there shouldn't be a python3.9/python3.10 version, the build arg even already exists?
### TESTING INSTRUCTIONS
Run the docker build and see it works with python3.9/python3.10
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [X] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a diff in pull request #22770: feat(docker): Build multiple python version images
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on code in PR #22770:
URL: https://github.com/apache/superset/pull/22770#discussion_r1083066119
##########
.github/workflows/docker_build_push.sh:
##########
@@ -50,12 +50,39 @@ docker build --target lean \
-t "${REPO_NAME}:${SHA}" \
-t "${REPO_NAME}:${REFSPEC}" \
-t "${REPO_NAME}:${LATEST_TAG}" \
+ --build-arg PY_VER="3.8.16"\
--label "sha=${SHA}" \
--label "built_at=$(date)" \
--label "target=lean" \
--label "build_actor=${GITHUB_ACTOR}" \
.
+# Build the "lean39" image
+docker build --target lean \
+ -t "${REPO_NAME}:${SHA}-py39" \
+ -t "${REPO_NAME}:${REFSPEC}-py39" \
+ -t "${REPO_NAME}:${LATEST_TAG}-py39" \
+ --build-arg PY_VER="3.9.16"\
+ --label "sha=${SHA}" \
+ --label "built_at=$(date)" \
+ --label "target=lean39" \
+ --label "build_actor=${GITHUB_ACTOR}" \
+ .
+
+
+# Build the "lean310" image
+docker build --target lean \
Review Comment:
Let's only go with `3.9` for now as `3.10` isn't tested yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Germandrummer92 commented on pull request #22770: feat(docker): Build multiple python version images
Posted by "Germandrummer92 (via GitHub)" <gi...@apache.org>.
Germandrummer92 commented on PR #22770:
URL: https://github.com/apache/superset/pull/22770#issuecomment-1399331236
Maybe there also should be a defined process of when the "next-python" image becomes the "main" python version?
python3.8 is still supported until next year, but in general I wouldn't mind if we only lag about 1 year behind the python release schedule? https://endoflife.date/python
That would mean we would try to move the "main" python image to 3.9 and have 3.10 support soon; and move to 3.10/3.11 in October when 3.12 releases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #22770: feat(docker): Build multiple python version images
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda merged PR #22770:
URL: https://github.com/apache/superset/pull/22770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a diff in pull request #22770: feat(docker): Build multiple python version images
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on code in PR #22770:
URL: https://github.com/apache/superset/pull/22770#discussion_r1083061276
##########
.github/workflows/docker_build_push.sh:
##########
@@ -50,12 +50,39 @@ docker build --target lean \
-t "${REPO_NAME}:${SHA}" \
-t "${REPO_NAME}:${REFSPEC}" \
-t "${REPO_NAME}:${LATEST_TAG}" \
+ --build-arg PY_VER="3.8.16"\
--label "sha=${SHA}" \
--label "built_at=$(date)" \
--label "target=lean" \
--label "build_actor=${GITHUB_ACTOR}" \
.
+# Build the "lean39" image
+docker build --target lean \
+ -t "${REPO_NAME}:${SHA}-py39" \
+ -t "${REPO_NAME}:${REFSPEC}-py39" \
+ -t "${REPO_NAME}:${LATEST_TAG}-py39" \
+ --build-arg PY_VER="3.9.16"\
+ --label "sha=${SHA}" \
+ --label "built_at=$(date)" \
+ --label "target=lean39" \
Review Comment:
I don't think this target exists in the `Dockerfile`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22770: feat(docker): Build multiple python version images
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #22770:
URL: https://github.com/apache/superset/pull/22770#issuecomment-1398922236
Seems related to https://github.com/apache/superset/discussions/22810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Germandrummer92 commented on a diff in pull request #22770: feat(docker): Build multiple python version images
Posted by "Germandrummer92 (via GitHub)" <gi...@apache.org>.
Germandrummer92 commented on code in PR #22770:
URL: https://github.com/apache/superset/pull/22770#discussion_r1083334047
##########
.github/workflows/docker_build_push.sh:
##########
@@ -50,12 +50,39 @@ docker build --target lean \
-t "${REPO_NAME}:${SHA}" \
-t "${REPO_NAME}:${REFSPEC}" \
-t "${REPO_NAME}:${LATEST_TAG}" \
+ --build-arg PY_VER="3.8.16"\
--label "sha=${SHA}" \
--label "built_at=$(date)" \
--label "target=lean" \
--label "build_actor=${GITHUB_ACTOR}" \
.
+# Build the "lean39" image
+docker build --target lean \
+ -t "${REPO_NAME}:${SHA}-py39" \
+ -t "${REPO_NAME}:${REFSPEC}-py39" \
+ -t "${REPO_NAME}:${LATEST_TAG}-py39" \
+ --build-arg PY_VER="3.9.16"\
+ --label "sha=${SHA}" \
+ --label "built_at=$(date)" \
+ --label "target=lean39" \
+ --label "build_actor=${GITHUB_ACTOR}" \
+ .
+
+
+# Build the "lean310" image
+docker build --target lean \
Review Comment:
removed 3.10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Germandrummer92 commented on pull request #22770: feat(docker): Build multiple python version images
Posted by "Germandrummer92 (via GitHub)" <gi...@apache.org>.
Germandrummer92 commented on PR #22770:
URL: https://github.com/apache/superset/pull/22770#issuecomment-1399330161
@rusackas I removed the patch version now and switched back to the -slim version. Let me know if that makes sense or if we should stay with the pinned patch version.
I think -slim for sure makes sense if it works, which it did before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org