You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/03/31 18:22:47 UTC
[kudu-CR] [codegen] use std::atomic instead of AtomicInt
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21225
Change subject: [codegen] use std::atomic instead of AtomicInt
......................................................................
[codegen] use std::atomic instead of AtomicInt
The chromium-based atomics are deprecated in favor of std::atomic
from the STL: this patch switches from AtomicInt to std::atomic
for the codegen's compilation manager. I changes the corresponding
metrics from int64_t to uint64_t type.
There are functional modifications in this changelist.
Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92
---
M src/kudu/codegen/compilation_manager.cc
M src/kudu/codegen/compilation_manager.h
2 files changed, 36 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/21225/1
--
To view, visit http://gerrit.cloudera.org:8080/21225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92
Gerrit-Change-Number: 21225
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [codegen] use std::atomic instead of AtomicInt
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [codegen] use std::atomic instead of AtomicInt
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92
Gerrit-Change-Number: 21225
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [codegen] use std::atomic instead of AtomicInt
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Yifan Zhang, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21225
to look at the new patch set (#2).
Change subject: [codegen] use std::atomic instead of AtomicInt
......................................................................
[codegen] use std::atomic instead of AtomicInt
The chromium-based atomics are deprecated in favor of std::atomic
from the STL: this patch switches from AtomicInt to std::atomic
for the codegen's compilation manager. I changes the corresponding
metrics from int64_t to uint64_t type.
This patch doesn't contain any functional modifications.
Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92
---
M src/kudu/codegen/compilation_manager.cc
M src/kudu/codegen/compilation_manager.h
2 files changed, 36 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/21225/2
--
To view, visit http://gerrit.cloudera.org:8080/21225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92
Gerrit-Change-Number: 21225
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [codegen] use std::atomic instead of AtomicInt
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21225 )
Change subject: [codegen] use std::atomic instead of AtomicInt
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92
Gerrit-Change-Number: 21225
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 01 Apr 2024 04:06:15 +0000
Gerrit-HasComments: No
[kudu-CR] [codegen] use std::atomic instead of AtomicInt
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21225 )
Change subject: [codegen] use std::atomic instead of AtomicInt
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21225/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21225/1//COMMIT_MSG@14
PS1, Line 14: are
Missing "no"?
--
To view, visit http://gerrit.cloudera.org:8080/21225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92
Gerrit-Change-Number: 21225
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 01 Apr 2024 02:11:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [codegen] use std::atomic instead of AtomicInt
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21225 )
Change subject: [codegen] use std::atomic instead of AtomicInt
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21225/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21225/1//COMMIT_MSG@14
PS1, Line 14: are
> Missing "no"?
Done
--
To view, visit http://gerrit.cloudera.org:8080/21225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92
Gerrit-Change-Number: 21225
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 01 Apr 2024 03:33:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] [codegen] use std::atomic instead of AtomicInt
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21225 )
Change subject: [codegen] use std::atomic instead of AtomicInt
......................................................................
[codegen] use std::atomic instead of AtomicInt
The chromium-based atomics are deprecated in favor of std::atomic
from the STL: this patch switches from AtomicInt to std::atomic
for the codegen's compilation manager. I changes the corresponding
metrics from int64_t to uint64_t type.
This patch doesn't contain any functional modifications.
Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92
Reviewed-on: http://gerrit.cloudera.org:8080/21225
Reviewed-by: Yingchun Lai <la...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/codegen/compilation_manager.cc
M src/kudu/codegen/compilation_manager.h
2 files changed, 36 insertions(+), 29 deletions(-)
Approvals:
Yingchun Lai: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92
Gerrit-Change-Number: 21225
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [codegen] use std::atomic instead of AtomicInt
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21225 )
Change subject: [codegen] use std::atomic instead of AtomicInt
......................................................................
Patch Set 2: Verified+1
unrelated test failures
--
To view, visit http://gerrit.cloudera.org:8080/21225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3271ef420163a6d996645bb60aa8d475c7925f92
Gerrit-Change-Number: 21225
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 01 Apr 2024 06:21:31 +0000
Gerrit-HasComments: No