[GitHub] [incubator-superset] john-bodley commented on pull request #11998: fix: SIP-15 time_range_endpoints not using default option

[GitBox <gi...@apache.org>]

john-bodley commented on pull request #11998:
URL: https://github.com/apache/incubator-superset/pull/11998#issuecomment-748638668


   @rubenSastre I believe there's a disconnect between you PR description and code change. The existing code (at least in the places you changed) seems correct to me, i.e., we always want to ensure new slices and all slices after the grace period ends adhere to the `[start, end)` interval definition. 
   
   More specifically, the target (desired) time interval is purposely not configurable (and thus is hard coded). The source intervals may vary by institution and can be defined at the database level or fallback to the configuration file if undefined per [here](https://github.com/apache/incubator-superset/blob/4d329071a1651994574c3ad1f26e32b56d9ff810/superset/views/utils.py#L285-L301).
   
   What is the specific issue you're facing? The disconnect in your two screenshots could be because either:
   
   1. The slice is a new slice.
   2. The grace period has expired.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org