You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Timothy Bish (JIRA)" <ji...@apache.org> on 2018/06/29 19:48:00 UTC

[jira] [Comment Edited] (ARTEMIS-1941) broker changes AMQP body section type during 'Large' message handling

    [ https://issues.apache.org/jira/browse/ARTEMIS-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528142#comment-16528142 ] 

Timothy Bish edited comment on ARTEMIS-1941 at 6/29/18 7:47 PM:
----------------------------------------------------------------

Github integration seems to be down:

{quote}

GitHub user tabish121 opened a pull request:

[https://github.com/apache/activemq-artemis/pull/2168]

RTEMIS-1941 Preserve AMQP body section type on "large" messages When "large" messages are converted to / from core in order to be stored in the large message store the type of the AMQP body section is being lost and reconstituted incorrectly in some cases. The message needs to be annotated with the original AMQP type for the body and that used to manage the conversion back to AMQP from Core. You can merge this pull request into a Git repository by running: $ git pull

[https://github.com/tabish121/activemq-artemis]

ARTEMIS-1941 Alternatively you can review and apply these changes as the patch at:

[https://github.com/apache/activemq-artemis/pull/2168.patch]

To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2168 ---- commit 9780b275ea03e4c587a6e808e4e5214ff7bb2548 Author: Timothy Bish

[<ta...@...>|mailto:tabish121@...]

Date: 2018-06-29T19:22:05Z ARTEMIS-1941 Preserve AMQP body section type on "large" messages When "large" messages are converted to / from core in order to be stored in the large message store the type of the AMQP body section is being lost and reconstituted incorrectly in some cases. The message needs to be annotated with the original AMQP type for the body and that used to manage the conversion back to AMQP from Core.

{quote}


was (Author: tabish121):
Github integration seems to be down:

{noformat}

GitHub user tabish121 opened a pull request:

[https://github.com/apache/activemq-artemis/pull/2168]

RTEMIS-1941 Preserve AMQP body section type on "large" messages When "large" messages are converted to / from core in order to be stored in the large message store the type of the AMQP body section is being lost and reconstituted incorrectly in some cases. The message needs to be annotated with the original AMQP type for the body and that used to manage the conversion back to AMQP from Core. You can merge this pull request into a Git repository by running: $ git pull

[https://github.com/tabish121/activemq-artemis]

ARTEMIS-1941 Alternatively you can review and apply these changes as the patch at:

[https://github.com/apache/activemq-artemis/pull/2168.patch]

To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2168 ---- commit 9780b275ea03e4c587a6e808e4e5214ff7bb2548 Author: Timothy Bish

[<ta...@...>|mailto:tabish121@...]

Date: 2018-06-29T19:22:05Z ARTEMIS-1941 Preserve AMQP body section type on "large" messages When "large" messages are converted to / from core in order to be stored in the large message store the type of the AMQP body section is being lost and reconstituted incorrectly in some cases. The message needs to be annotated with the original AMQP type for the body and that used to manage the conversion back to AMQP from Core.

{noformat}

> broker changes AMQP body section type during 'Large' message handling
> ---------------------------------------------------------------------
>
>                 Key: ARTEMIS-1941
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1941
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: AMQP
>    Affects Versions: 2.6.1
>            Reporter: Robbie Gemmell
>            Priority: Major
>
> When the broker receives AMQP messages it considers those over a certain size (currently the lower of journal file size and journal buffer size, ~500KB default) to be a 'large' message. In its handling of these, the message is essentially converted internally to a Core message, and when sending the message to an AMQP consumer, essentially gets converted back. During investigation of and testing of ARTEMIS-1940 I noted that although my test sent in an AMQP Data body section and so that is what should come back out, I instead received an AMQP Value body section containing a binary value (with the same bytes).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)