[GitHub] [skywalking] innerpeacez commented on pull request #6686: Add Dockerfile and build script for Java agent Docker image

[GitBox <gi...@apache.org>]

innerpeacez commented on pull request #6686:
URL: https://github.com/apache/skywalking/pull/6686#issuecomment-813802345


   > [#6686 (comment)](https://github.com/apache/skywalking/pull/6686#discussion_r607425217)
   > 
   > Let me make it more clear (hopefully)
   > 
   > We will finally have some agent images like `apache/skywalking-java-agent:<skywalking-version>-<jdk-version>`, such as `apache/skywalking-java-agent:8.5.0-jdk11`, `apache/skywalking-java-agent:8.5.0-jre8`, etc. all of which have built-in JVM options, configurations to enable the users just replace their original base image of a Java application and the SkyWalking agent is automatically installed, for example:
   > 
   > ```dockerfile
   > // FROM openjdk:8 // user's original base image
   > FROM apache/skywalking-java-agent:8.5.0-jdk8 // only need to replace with this and the agent should be installed automatically
   > 
   > // Other existing stuff, including their start up command without `-javaagent` option, they don't need to be aware of this at all
   > ```
   > 
   > If, however, the users want to minimize their application image, or want to do some hacking in the agent, they can do something like:
   > 
   > ```dockerfile
   > FROM apache/skywalking-java-agent:8.5.0-jdk8 as agent // use our agent image as intermediate layer
   > 
   > // Do whatever users want, to minimize the image or anything else
   > ```
   > 
   > We can also have a minimized image `apache/skywalking-java-agent:8.5.0-scratch` which only includes the agent files based on `scratch` (or `alpine`) image.
   
   Clearer, Looks good :) thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org