You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/02/18 02:04:14 UTC
[GitHub] [incubator-apisix] membphis opened a new pull request #1134:
bugfix: missing `clear` table before to reuse table.
membphis opened a new pull request #1134: bugfix: missing `clear` table before to reuse table.
URL: https://github.com/apache/incubator-apisix/pull/1134
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1134: bugfix: missing `clear` table before to reuse table.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1134: bugfix: missing `clear` table before to reuse table.
URL: https://github.com/apache/incubator-apisix/pull/1134#discussion_r380657179
##########
File path: lua/apisix/core/response.lua
##########
@@ -37,10 +37,12 @@ do
local idx = 1
function resp_exit(code, ...)
+ clear_tab(t)
idx = 0
if code and type(code) ~= "number" then
- insert_tab(t, code)
Review comment:
Always insert new data and then memory leak.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis merged pull request #1134: bugfix:
missing `clear` table before to reuse table.
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1134: bugfix: missing `clear` table before to reuse table.
URL: https://github.com/apache/incubator-apisix/pull/1134
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on issue #1134: bugfix:
missing `clear` table before to reuse table.
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1134: bugfix: missing `clear` table before to reuse table.
URL: https://github.com/apache/incubator-apisix/pull/1134#issuecomment-587445558
need to add more infomation about this bug: memory leak?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1134: bugfix:
missing `clear` table before to reuse table.
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1134: bugfix: missing `clear` table before to reuse table.
URL: https://github.com/apache/incubator-apisix/pull/1134#issuecomment-587449561
> need to add more infomation about this bug: memory leak?
please take a look at: https://github.com/apache/incubator-apisix/pull/1134/files#r380657179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#1134: bugfix: missing `clear` table before to reuse table.
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1134: bugfix: missing `clear` table before to reuse table.
URL: https://github.com/apache/incubator-apisix/pull/1134#discussion_r380632837
##########
File path: t/admin/routes.t
##########
@@ -1369,6 +1369,7 @@ passed
location /t {
content_by_lua_block {
local t = require("lib.test_admin").test
+ local core = require("apisix.core")
Review comment:
why change this test case file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1134: bugfix: missing `clear` table before to reuse table.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1134: bugfix: missing `clear` table before to reuse table.
URL: https://github.com/apache/incubator-apisix/pull/1134#discussion_r380650710
##########
File path: t/admin/routes.t
##########
@@ -1369,6 +1369,7 @@ passed
location /t {
content_by_lua_block {
local t = require("lib.test_admin").test
+ local core = require("apisix.core")
Review comment:
that is a not related thing. Travis report failed sometimes because of this test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1134: bugfix:
missing `clear` table before to reuse table.
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1134: bugfix: missing `clear` table before to reuse table.
URL: https://github.com/apache/incubator-apisix/pull/1134#issuecomment-587238663
this PR depends on https://github.com/apache/incubator-apisix/pull/1129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services