[jira] [Commented] (HBASE-21494) NPE when loading RecoverStandByProcedure

["Duo Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-21494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690537#comment-16690537 ] 

Duo Zhang commented on HBASE-21494:
-----------------------------------

OK the problem is that we initialize the SyncReplicationReplayWALManager in the initializeZKBasedSystemTrackers, which is after we load procedures. We should move it before we load procedures. Will prepare a patch soon. The fix is easy, but we need to UT.

> NPE when loading RecoverStandByProcedure
> ----------------------------------------
>
>                 Key: HBASE-21494
>                 URL: https://issues.apache.org/jira/browse/HBASE-21494
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Replication
>            Reporter: Duo Zhang
>            Priority: Major
>             Fix For: 3.0.0
>
>
> {noformat}
> 2018-11-16,21:06:04,676 ERROR [master/c4-hadoop-tst-ct05:19100:becomeActiveMaster] org.apache.hadoop.hbase.master.HMaster: Failed to become active master
> java.lang.NullPointerException
>         at org.apache.hadoop.hbase.master.replication.RecoverStandbyProcedure.afterReplay(RecoverStandbyProcedure.java:151)
>         at org.apache.hadoop.hbase.master.replication.RecoverStandbyProcedure.afterReplay(RecoverStandbyProcedure.java:39)
>         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.lambda$loadProcedures$1(ProcedureExecutor.java:524)
>         at java.util.ArrayList.forEach(ArrayList.java:1249)
>         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.loadProcedures(ProcedureExecutor.java:509)
>         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$400(ProcedureExecutor.java:78)
>         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.load(ProcedureExecutor.java:330)
>         at org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore$2.load(WALProcedureStore.java:474)
>         at org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.finish(ProcedureWALFormatReader.java:148)
>         at org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:103)
>         at org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:465)
>         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:321)
>         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:596)
>         at org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1517)
>         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:947)
>         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2311)
>         at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:587)
>         at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)