You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "hdygxsj (via GitHub)" <gi...@apache.org> on 2024/05/28 12:16:21 UTC
[PR] [Feature] Add dockerfile for building docker image. [paimon-webui]
hdygxsj opened a new pull request, #264:
URL: https://github.com/apache/paimon-webui/pull/264
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
Add dockerfile for building docker image.
```dockerfile
FROM eclipse-temurin:8-jre
ENV DOCKER true
ENV TZ Asia/Shanghai
ENV PAIMON_UI_HOME /opt/PAIMON_UI_HOME
WORKDIR $PAIMON_UI_HOME
ADD ./target/paimon-web-server $PAIMON_UI_HOME
EXPOSE 10088
CMD [ "/bin/bash", "./bin/start.sh" ]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add dockerfile for building docker image [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #264:
URL: https://github.com/apache/paimon-webui/pull/264#discussion_r1644832102
##########
paimon-web-server/src/main/docker/Dockerfile:
##########
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+ARG java_image_tag=8-jdk-focal
+FROM eclipse-temurin:${java_image_tag}
+
+ENV DOCKER true
+ENV TZ Asia/Shanghai
+ENV PAIMON_UI_HOME /opt/paimon-webui
+
+COPY target/paimon-web-server $PAIMON_UI_HOME
+
+RUN useradd paimon && \
+ chown -R paimon:paimon $PAIMON_UI_HOME
Review Comment:
Does this need to `chmod a+x` for script directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add dockerfile for building docker image. [paimon-webui]
Posted by "hdygxsj (via GitHub)" <gi...@apache.org>.
hdygxsj commented on code in PR #264:
URL: https://github.com/apache/paimon-webui/pull/264#discussion_r1634890459
##########
paimon-web-server/src/main/docker/Dockerfile:
##########
@@ -0,0 +1,30 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM eclipse-temurin:8-jre
Review Comment:
eclipse-temurin:8-jre is a Docker image based on the Eclipse Temurin project, specifically providing the Java 8 Runtime Environment (JRE). Eclipse Temurin is part of the Adoptium project, which carries on the work from AdoptOpenJDK, delivering open-source, rigorously tested, and OpenJDK-compatible binary distributions. When you see eclipse-temurin:8-jre, it refers to a lightweight runtime environment tailored for Java 8, intended for scenarios where the full development kit (JDK) is not necessary. It includes only the components required to run Java applications, such as the Java Virtual Machine (JVM) and core class libraries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add dockerfile for building docker image [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #264:
URL: https://github.com/apache/paimon-webui/pull/264#discussion_r1644833014
##########
paimon-web-server/src/main/docker/Dockerfile:
##########
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+ARG java_image_tag=8-jdk-focal
+FROM eclipse-temurin:${java_image_tag}
+
+ENV DOCKER true
+ENV TZ Asia/Shanghai
+ENV PAIMON_UI_HOME /opt/paimon-webui
+
+COPY target/paimon-web-server $PAIMON_UI_HOME
+
+RUN useradd paimon && \
+ chown -R paimon:paimon $PAIMON_UI_HOME
+
+USER paimon
+
+WORKDIR $PAIMON_UI_HOME
+
+EXPOSE 10088
+
+CMD [ "/bin/bash", "./bin/start.sh"]
Review Comment:
Is the path of `start.sh` correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add dockerfile for building docker image [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #264: [Feature] Add dockerfile for building docker image
URL: https://github.com/apache/paimon-webui/pull/264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add dockerfile for building docker image [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #264:
URL: https://github.com/apache/paimon-webui/pull/264#issuecomment-2176634073
@hdygxsj, could you verify the image bulit by this Dockerfile locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add dockerfile for building docker image [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #264:
URL: https://github.com/apache/paimon-webui/pull/264#discussion_r1644106286
##########
paimon-web-server/src/main/docker/Dockerfile:
##########
@@ -0,0 +1,30 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM eclipse-temurin:8-jre
Review Comment:
```
ARG java_image_tag=8-jdk-focal
FROM eclipse-temurin:${java_image_tag}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add dockerfile for building docker image [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #264:
URL: https://github.com/apache/paimon-webui/pull/264#discussion_r1644833306
##########
paimon-web-server/src/main/docker/Dockerfile:
##########
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+ARG java_image_tag=8-jdk-focal
+FROM eclipse-temurin:${java_image_tag}
+
+ENV DOCKER true
+ENV TZ Asia/Shanghai
+ENV PAIMON_UI_HOME /opt/paimon-webui
+
+COPY target/paimon-web-server $PAIMON_UI_HOME
+
+RUN useradd paimon && \
+ chown -R paimon:paimon $PAIMON_UI_HOME
+
+USER paimon
+
+WORKDIR $PAIMON_UI_HOME
+
+EXPOSE 10088
+
+CMD [ "/bin/bash", "./bin/start.sh"]
Review Comment:
Is the path of `start.sh` correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add dockerfile for building docker image. [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #264:
URL: https://github.com/apache/paimon-webui/pull/264#discussion_r1629087241
##########
paimon-web-server/src/main/docker/Dockerfile:
##########
@@ -0,0 +1,30 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM eclipse-temurin:8-jre
Review Comment:
Why use this image?
##########
paimon-web-server/src/main/docker/Dockerfile:
##########
@@ -0,0 +1,30 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM eclipse-temurin:8-jre
+
+ENV DOCKER true
+ENV TZ Asia/Shanghai
+ENV PAIMON_UI_HOME /opt/paimon-webui
+
+WORKDIR $PAIMON_UI_HOME
+
+ADD ./target/paimon-web-server $PAIMON_UI_HOME
Review Comment:
Does this need to regard `./target/paimon-web-server` as `PAIMON_UI_HOME`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add dockerfile for building docker image [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #264:
URL: https://github.com/apache/paimon-webui/pull/264#discussion_r1644110040
##########
paimon-web-server/src/main/docker/Dockerfile:
##########
@@ -0,0 +1,30 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM eclipse-temurin:8-jre
+
+ENV DOCKER true
+ENV TZ Asia/Shanghai
+ENV PAIMON_UI_HOME /opt/paimon-webui
+
+WORKDIR $PAIMON_UI_HOME
+
+ADD ./target/paimon-web-server $PAIMON_UI_HOME
+
+EXPOSE 10088
+
+CMD [ "/bin/bash", "./bin/start.sh" ]
Review Comment:
USER paimon
WORKDIR $PAIMON_UI_HOME
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add dockerfile for building docker image [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #264:
URL: https://github.com/apache/paimon-webui/pull/264#discussion_r1644108496
##########
paimon-web-server/src/main/docker/Dockerfile:
##########
@@ -0,0 +1,30 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM eclipse-temurin:8-jre
+
+ENV DOCKER true
+ENV TZ Asia/Shanghai
+ENV PAIMON_UI_HOME /opt/paimon-webui
+
+WORKDIR $PAIMON_UI_HOME
+
+ADD ./target/paimon-web-server $PAIMON_UI_HOME
Review Comment:
`COPY target/paimon-web-server/* $PAIMON_UI_HOME`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add dockerfile for building docker image [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #264:
URL: https://github.com/apache/paimon-webui/pull/264#discussion_r1644831334
##########
paimon-web-server/src/main/docker/Dockerfile:
##########
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+ARG java_image_tag=8-jdk-focal
+FROM eclipse-temurin:${java_image_tag}
+
+ENV DOCKER true
Review Comment:
Why add `DOCKER` and `TZ`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add dockerfile for building docker image. [paimon-webui]
Posted by "hdygxsj (via GitHub)" <gi...@apache.org>.
hdygxsj commented on code in PR #264:
URL: https://github.com/apache/paimon-webui/pull/264#discussion_r1634933960
##########
paimon-web-server/src/main/docker/Dockerfile:
##########
@@ -0,0 +1,30 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM eclipse-temurin:8-jre
+
+ENV DOCKER true
+ENV TZ Asia/Shanghai
+ENV PAIMON_UI_HOME /opt/paimon-webui
+
+WORKDIR $PAIMON_UI_HOME
+
+ADD ./target/paimon-web-server $PAIMON_UI_HOME
Review Comment:
His statement means that when the Docker command is executed, the contents of the ./target/paimon-web-server directory will be copied into the PAIMON_UI_HOME directory within the container. This Dockerfile is designed such that during the Maven build process, the image can be pushed to DockerHub.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org