You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/19 14:59:30 UTC
[GitHub] flink pull request #3954: [FLINK-6628] Fix start scripts on Windows
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3954
[FLINK-6628] Fix start scripts on Windows
This PR fixes the `flink-daemon.sh` and `taskmanager.sh` script for cygwin for directories containing spaces.
They were broken in 11c868f91db773af626ac6ac4dcba9820c13fa8a.
The change in the daemon script is straight-forward; to prevent the path containing the space to be interpreted as to arguments we wrap it in `"` which causes the entire path, including the space, to be passed as a single argument.
The change in the taskmanager script is as subtle as it gets. When storing the call like this `TM_COMMAND="${FLINK_BIN_DIR}/flink-daemon.sh $STARTSTOP taskmanager ${args[@]}"` and executing it later spaces are once again used as to separate arguments, breaking the execution. We can't use the trick used above, since then the entire expressions is used as a single argument (i.e. path to an executable) which obviously fails.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6628_win_script
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3954.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3954
----
commit f4da72abc7d8d5c380f4552eead69ee477833c8a
Author: zentol <ch...@apache.org>
Date: 2017-05-19T14:50:37Z
[FLINK-6628] Fix start scripts on Windows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3954: [FLINK-6628] Fix start scripts on Windows
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3954
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3954: [FLINK-6628] Fix start scripts on Windows
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3954
+1 and to fix in 1.3.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3954: [FLINK-6628] Fix start scripts on Windows
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3954
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3954: [FLINK-6628] Fix start scripts on Windows
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3954
@greghogan done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3954: [FLINK-6628] Fix start scripts on Windows
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3954
This affects more than Windows ... at least MacOS and I expect Linux as well.
Also need to update `rotateLogFilesWithPrefix` in `config.sh` to: `rotateLogFile "$log"`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---