[GitHub] [zeppelin] zjffdu commented on a change in pull request #4210: [ZEPPELIN-5501] Interpreter shade

[GitBox <gi...@apache.org>]

zjffdu commented on a change in pull request #4210:
URL: https://github.com/apache/zeppelin/pull/4210#discussion_r697226217



##########
File path: zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
##########
@@ -16,10 +16,9 @@
  */
 package org.apache.zeppelin.socket;
 
-import com.google.common.base.Strings;
-import com.google.gson.Gson;
-import com.google.gson.GsonBuilder;
-import com.google.gson.reflect.TypeToken;
+import shaded.com.google.gson.Gson;
+import shaded.com.google.gson.GsonBuilder;
+import shaded.com.google.gson.reflect.TypeToken;

Review comment:
       Why use shaded class in zeppelin-server ? The reason we introduce  `zeppelin-interpreter-shaded` is to avoid conflict between `zeppelin-interpreter` and other third party dependencies used by specific interpreter (e.g. zeppelin-interpreter's dependencies conflicts with spark's dependencies). There should be no jar conflict issue in zeppelin server process, so seems no necessary to use shaded class in zeppelin-server. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org