You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/04/11 14:51:32 UTC
[GitHub] nikitap492 commented on issue #1069: Replaced ObjectUtils for
java.utils.Objects methods
nikitap492 commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods
URL: https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380480827
There is no defference between these two methods. It is just a good practice to use already written methods, because it's more familiar for other developers.
Could you look at `InstanceCacheGuavaService`, for example. The methods `getApplicationId` , `getInstanceIdByAgentUUID` and `getInstanceIdByAddressId` had very similar code and few difference. I tried to generalize it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services