You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/20 04:41:39 UTC
[GitHub] [doris] xinyiZzz opened a new pull request, #11939: [fix](memtracker) Remove useless memory exceed check
xinyiZzz opened a new pull request, #11939:
URL: https://github.com/apache/doris/pull/11939
# Proposed changes
Issue Number: close #xxx
## Problem summary
When the query mem tracker exceed limit, the query will be quickly canceled, and `sleep_for` and `_writer_cond.wait_for` are meaningless.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] freemandealer commented on a diff in pull request #11939: [fix](memtracker) Remove useless memory exceed check
Posted by GitBox <gi...@apache.org>.
freemandealer commented on code in PR #11939:
URL: https://github.com/apache/doris/pull/11939#discussion_r956656266
##########
be/src/exec/tablet_sink.cpp:
##########
@@ -302,8 +302,7 @@ Status NodeChannel::add_row(Tuple* input_tuple, int64_t tablet_id) {
// _cancelled may be set by rpc callback, and it's possible that _cancelled might be set in any of the steps below.
// It's fine to do a fake add_row() and return OK, because we will check _cancelled in next add_row() or mark_close().
while (!_cancelled && _pending_batches_num > 0 &&
- (_pending_batches_bytes > _max_pending_batches_bytes ||
- _parent->_mem_tracker->limit_exceeded(_max_pending_batches_bytes))) {
Review Comment:
this is not only useless but a performance bug which will cause unnecessary sleep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #11939: [fix](memtracker) Remove useless memory exceed check
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11939:
URL: https://github.com/apache/doris/pull/11939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] kpfly commented on a diff in pull request #11939: [fix](memtracker) Remove useless memory exceed check
Posted by GitBox <gi...@apache.org>.
kpfly commented on code in PR #11939:
URL: https://github.com/apache/doris/pull/11939#discussion_r956662011
##########
be/src/exec/tablet_sink.cpp:
##########
@@ -302,8 +302,7 @@ Status NodeChannel::add_row(Tuple* input_tuple, int64_t tablet_id) {
// _cancelled may be set by rpc callback, and it's possible that _cancelled might be set in any of the steps below.
// It's fine to do a fake add_row() and return OK, because we will check _cancelled in next add_row() or mark_close().
while (!_cancelled && _pending_batches_num > 0 &&
- (_pending_batches_bytes > _max_pending_batches_bytes ||
- _parent->_mem_tracker->limit_exceeded(_max_pending_batches_bytes))) {
Review Comment:
> this is not only useless but a performance bug which will cause unnecessary sleep.
Is there any performance tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org