You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/08/20 00:02:36 UTC

[GitHub] [trafficcontrol] zrhoffman opened a new pull request #6128: Skip check for the past dbversion's migration existing if it is squashed

zrhoffman opened a new pull request #6128:
URL: https://github.com/apache/trafficcontrol/pull/6128

<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:

Closes: #ISSUE
Related: #ISSUE

If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
This PR
- Fixes an issue introduced by #6096 where, where when migrating from Goose, `db/admin dbversion` would return `0` instead of Goose migration version (e080781e61)
- Fixes the issue that #6096 was supposed to fix: Running the first unsquashed migration without checking whether the past migration exists if migrating from the last squashed migration (f102c654ff).
- Fixes a bug in the Traffic Ops DB tests where `dropdb` did not specify the database to drop

<hr>

## Which Traffic Control components are affected by this PR?

- Traffic Ops

## What is the best way to verify this PR?

1. Delete the `2021080408053529_fix_indices` migrations (unnecessary once #6127 is fixed)
2. Migrate the Traffic Ops database at [ATC 5.1.2](https://github.com/apache/trafficcontrol/commits/RELEASE-5.1.2)
3. Dump the database, move the dump to `traffic_ops_db/test/docker/initdb.d`, and rebuild the `db` service
4. Build a Traffic Ops RPM, move it to `traffic_ops_db/test/docker/traffic_ops.rpm` and rebuild the `trafficops-db-admin` service
5. Run the Traffic Ops DB tests

## If this is a bugfix, which Traffic Control versions contained the bug?

- 6.0.x release branch

## PR submission checklist
- [x] This PR modifies existing tests
- [ ] This PR has documentation 
- [ ] This PR has a CHANGELOG.md entry 
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)

<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org