You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/19 07:47:52 UTC
[GitHub] [spark] sarutak commented on a change in pull request #34664: [SPARK-35672][FOLLOWUP][TESTS] Add more exclusion rules to MimaExcludes.scala for Scala 2.13
sarutak commented on a change in pull request #34664:
URL: https://github.com/apache/spark/pull/34664#discussion_r752926070
##########
File path: project/MimaExcludes.scala
##########
@@ -37,8 +37,10 @@ object MimaExcludes {
// Exclude rules for 3.3.x from 3.2.0
lazy val v33excludes = v32excludes ++ Seq(
// [SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line
- // This is necessary for Scala 2.13.
+ // The followings are necessary for Scala 2.13.
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.executor.CoarseGrainedExecutorBackend#Arguments.*"),
+ ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.executor.CoarseGrainedExecutorBackend#Arguments.*"),
+ ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.executor.CoarseGrainedExecutorBackend$Arguments$")
Review comment:
Yeah, I think so.The parameter list of the class `Arguments` was changed (`userClassPath` was removed) in SPARK-35672, which caused the class hierarchy of the class `$Arguments$`.
```
$ javap core/target/scala-2.13/classes/org/apache/spark/executor/CoarseGrainedExecutorBackend\$Arguments\$.class
Compiled from "CoarseGrainedExecutorBackend.scala"
public class org.apache.spark.executor.CoarseGrainedExecutorBackend$Arguments$ extends scala.runtime.AbstractFunction9<java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Object, java.lang.String, scala.Option<java.lang.String>, scala.Option<java.lang.String>, java.lang.Object, org.apache.spark.executor.CoarseGrainedExecutorBackend$Arguments> implements java.io.Serializable {
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org