You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "rhh777 (via GitHub)" <gi...@apache.org> on 2023/12/27 04:35:56 UTC

[PR] Kyuubi tpcds RunBenchmark support skip some of the queries [kyuubi]

rhh777 opened a new pull request, #5925:
URL: https://github.com/apache/kyuubi/pull/5925

   # :mag: Description
   ## Issue References πŸ”—
   <!-- Append the issue number after #. If there is no issue for you to link create one or -->
   <!-- If there are no issues to link, please provide details here. -->
   
   When running Kyuubi's TPCDS, some SQL runs slowly, but there are no parameters to skip it.
   
   ## Describe Your Solution πŸ”§
   
   Add the skip parameter, specifying a comma-separated list of SQL
   
   
   ## Types of changes :bookmark:
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   
   ## Test Plan πŸ§ͺ
   
   #### Behavior Without This Pull Request :coffin:
   no parameters to skip it.
   
   #### Behavior With This Pull Request :tada:
   ```
   $SPARK_HOME/bin/spark-submit \
     --class org.apache.kyuubi.tpcds.benchmark.RunBenchmark \
     kyuubi-tpcds_*.jar --db tpcds_sf10 --skip q2,q4
   ```
   
   > == QUERY LIST ==
   > q1-v2.4
   > q3-v2.4
   > q5-v2.4
   > q6-v2.4
   > q7-v2.4
   > q8-v2.4
   > q9-v2.4
   > .....
   
   #### Related Unit Tests
   
   
   ---
   
   # Checklists
   ## πŸ“ Author Self Checklist
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
   - [x] I have performed a self-review
   - [x] I have commented my code, particularly in hard-to-understand areas
   - [x] I have made corresponding changes to the documentation
   - [ ] My changes generate no new warnings
   - [ ] I have added tests that prove my fix is effective or that my feature works
   - [ ] New and existing unit tests pass locally with my changes
   - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
   
   ## πŸ“ Committer Pre-Merge Checklist
   
   - [ ] Pull request title is okay.
   - [ ] No license issues.
   - [ ] Milestone correctly set?
   - [ ] Test coverage is ok
   - [ ] Assignees are selected.
   - [ ] Minimum number of approvals
   - [ ] No changes are requested
   
   
   **Be nice. Be informative.**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "rhh777 (via GitHub)" <gi...@apache.org>.
rhh777 commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1869990405

   > how about changing `filter` to `include` and `skip` to `exclude`? And we should define the priority of these two options
   
   1. It sounds great, but now there is also the queries parameter. Its function is similar to filter. Filter can only include one SQL, and queries can include multiple SQLs.
   
   2. Regarding priority, I think exclude should always take precedence over include.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1870000216

   would it be clear if we replace the `queries` and `filter` with `include`(list) and `exclude`(list)? it's kind of a developer tool, such breaking changes are acceptable.
   
   for priority, especially when `include` and `exclude` are present at the same time, there are some candidates:
   1. the final result is `include` minus `exclude`
   2. as you proposed, simply ignore the `include`
   
   I lean to option 1, but both are fine, as long as we document the behavior clearly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "rhh777 (via GitHub)" <gi...@apache.org>.
rhh777 commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1871028207

   > BTW, it seems that πŸ“ Committer Pre-Merge Checklist is not welcomed at all. @pan3793
   
   Is it my job to fill in this list? I wasn't sure before. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1870008277

   that's fine, please go ahead


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1871029705

   thank you for your contribution and there is extra effort for you. @rhh777 
   this is a reviewer's field


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "rhh777 (via GitHub)" <gi...@apache.org>.
rhh777 commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1870969448

   > @rhh777 BTW, you may want to link your email [haorenhui@kingsoft.com](mailto:haorenhui@kingsoft.com) to your GitHub account, otherwise, your contribution will not be counted by GitHub :)
   Thanks, I'll adjust it later.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1871014021

   
   BTW, it seems that πŸ“ Committer Pre-Merge Checklist is not welcomed at all. @pan3793 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1869981520

   ## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5925?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base [(`c6177ab`)](https://app.codecov.io/gh/apache/kyuubi/commit/c6177ab2079381844cd02cd568533ddb584a34ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.57% compared to head [(`13744e5`)](https://app.codecov.io/gh/apache/kyuubi/pull/5925?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.57%.
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #5925   +/-   ##
   =========================================
     Coverage     61.57%   61.57%           
     Complexity       23       23           
   =========================================
     Files           616      616           
     Lines         36388    36388           
     Branches       4979     4979           
   =========================================
   + Hits          22405    22407    +2     
   + Misses        11568    11561    -7     
   - Partials       2415     2420    +5     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kyuubi/pull/5925?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1870961151

   @rhh777 BTW, you may want to link your email haorenhui@kingsoft.com to your GitHub account, otherwise, your contribution will not be counted by GitHub :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1870959889

   UT failure is unrelated, thanks, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "rhh777 (via GitHub)" <gi...@apache.org>.
rhh777 commented on code in PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#discussion_r1437336766


##########
dev/kyuubi-tpcds/src/main/scala/org/apache/kyuubi/tpcds/benchmark/RunBenchmark.scala:
##########
@@ -66,11 +63,16 @@ object RunBenchmark {
       opt[String]('r', "results-dir")
         .action((x, c) => c.copy(resultsDir = x))
         .text("dir to store benchmark results, e.g. hdfs://hdfs-nn:9870/pref")
-      opt[String]('q', "queries")
+      opt[String]('I', "include")

Review Comment:
   updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1870319107

   LGTM, only minor comments


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #5925: [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries
URL: https://github.com/apache/kyuubi/pull/5925


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi tpcds RunBenchmark support skip some of the queries [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1869948198

   how about changing `filter` to `include` and `skip` to `exclude`? And we should define the priority of these two options


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1871030271

   @rhh777 it's my responsibility to fill in the `committer checklist`, you just need to fill in the "Author Self Checklist"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#discussion_r1437045824


##########
dev/kyuubi-tpcds/README.md:
##########
@@ -48,14 +48,15 @@ $SPARK_HOME/bin/spark-submit \
 
 Support options:
 
-|     key     |        default         |                          description                          |
-|-------------|------------------------|---------------------------------------------------------------|
-| db          | none(required)         | the TPC-DS database                                           |
-| benchmark   | tpcds-v2.4-benchmark   | the name of application                                       |
-| iterations  | 3                      | the number of iterations to run                               |
-| breakdown   | false                  | whether to record breakdown results of an execution           |
-| filter      | a                      | filter on the name of the queries to run, e.g. q1-v2.4        |
-| results-dir | /spark/sql/performance | dir to store benchmark results, e.g. hdfs://hdfs-nn:9870/pref |
+| key         | default                | description                                                           |
+|-------------|------------------------|-----------------------------------------------------------------------|
+| db          | none(required)         | the TPC-DS database                                                   |
+| benchmark   | tpcds-v2.4-benchmark   | the name of application                                               |
+| iterations  | 3                      | the number of iterations to run                                       |
+| breakdown   | false                  | whether to record breakdown results of an execution                   |
+| results-dir | /spark/sql/performance | dir to store benchmark results, e.g. hdfs://hdfs-nn:9870/pref         |
+| include     | none(optional)         | name of the queries to run, use , split multiple name, e.g. q1,q2     |
+| exclude     | none(optional)         | name of the queries to exclude, use , split multiple name, e.g. q2,q4 |

Review Comment:
   ```suggestion
   | include     | none(optional)         | name of the queries to run, use comma to split multiple names, e.g. q1,q2     |
   | exclude     | none(optional)         | name of the queries to exclude, use comma to split multiple names, e.g. q2,q4 |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "rhh777 (via GitHub)" <gi...@apache.org>.
rhh777 commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1870006690

   It's cleaner to just keep include and exclude in the end. I can make changes.
   
   My previous description of priority may have some misunderstandings. The meaning of exclude taking precedence over include is the same as option 1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#discussion_r1437047673


##########
dev/kyuubi-tpcds/src/main/scala/org/apache/kyuubi/tpcds/benchmark/RunBenchmark.scala:
##########
@@ -66,11 +63,16 @@ object RunBenchmark {
       opt[String]('r', "results-dir")
         .action((x, c) => c.copy(resultsDir = x))
         .text("dir to store benchmark results, e.g. hdfs://hdfs-nn:9870/pref")
-      opt[String]('q', "queries")
+      opt[String]('I', "include")

Review Comment:
   the short opt is confusing, let's keep the long one only 



##########
dev/kyuubi-tpcds/README.md:
##########
@@ -48,14 +48,15 @@ $SPARK_HOME/bin/spark-submit \
 
 Support options:
 
-|     key     |        default         |                          description                          |
-|-------------|------------------------|---------------------------------------------------------------|
-| db          | none(required)         | the TPC-DS database                                           |
-| benchmark   | tpcds-v2.4-benchmark   | the name of application                                       |
-| iterations  | 3                      | the number of iterations to run                               |
-| breakdown   | false                  | whether to record breakdown results of an execution           |
-| filter      | a                      | filter on the name of the queries to run, e.g. q1-v2.4        |
-| results-dir | /spark/sql/performance | dir to store benchmark results, e.g. hdfs://hdfs-nn:9870/pref |
+| key         | default                | description                                                           |
+|-------------|------------------------|-----------------------------------------------------------------------|
+| db          | none(required)         | the TPC-DS database                                                   |
+| benchmark   | tpcds-v2.4-benchmark   | the name of application                                               |
+| iterations  | 3                      | the number of iterations to run                                       |
+| breakdown   | false                  | whether to record breakdown results of an execution                   |
+| results-dir | /spark/sql/performance | dir to store benchmark results, e.g. hdfs://hdfs-nn:9870/pref         |
+| include     | none(optional)         | name of the queries to run, use , split multiple name, e.g. q1,q2     |
+| exclude     | none(optional)         | name of the queries to exclude, use , split multiple name, e.g. q2,q4 |

Review Comment:
   ```suggestion
   | include     | none(optional)         | name of the queries to run, use comma split multiple name, e.g. q1,q2     |
   | exclude     | none(optional)         | name of the queries to exclude, use comma split multiple name, e.g. q2,q4 |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1871038167

   > BTW, it seems that πŸ“ Committer Pre-Merge Checklist is not welcomed at all. @pan3793
   
   TBH, the checklist is too long, especially when there are images in the description and the network is slow, selecting the long checkbox makes the screen flicker many times. I prefer to the previous brief template, only listing a few most important items and leave others to scripts, e.g. checking assignees, milestone are selected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #5925] Kyuubi TPC-DS support running benchmark with skipping some queries [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5925:
URL: https://github.com/apache/kyuubi/pull/5925#issuecomment-1871040947

   BTW, I recommend avoid using emoji but prefer plain text in PR title and description, it doesn't render well on some platforms


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org