You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/04/11 23:32:49 UTC
[GitHub] [incubator-hudi] codecov-io commented on issue #1492: [WIP]
[HUDI-761] Refactoring rollback and restore actions using the
ActionExecutor abstraction
codecov-io commented on issue #1492: [WIP] [HUDI-761] Refactoring rollback and restore actions using the ActionExecutor abstraction
URL: https://github.com/apache/incubator-hudi/pull/1492#issuecomment-612535235
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1492?src=pr&el=h1) Report
> Merging [#1492](https://codecov.io/gh/apache/incubator-hudi/pull/1492?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/a464a2972e83e648585277ebe567703c8285cf1e&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `79.69%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1492/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1492?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1492 +/- ##
============================================
+ Coverage 72.20% 72.23% +0.03%
Complexity 289 289
============================================
Files 338 345 +7
Lines 15946 15987 +41
Branches 1624 1629 +5
============================================
+ Hits 11514 11549 +35
- Misses 3704 3708 +4
- Partials 728 730 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1492?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/hudi/client/AbstractHoodieWriteClient.java](https://codecov.io/gh/apache/incubator-hudi/pull/1492/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0Fic3RyYWN0SG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `77.77% <ø> (+3.62%)` | `0.00 <0.00> (ø)` | |
| [.../apache/hudi/exception/HoodieRestoreException.java](https://codecov.io/gh/apache/incubator-hudi/pull/1492/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0hvb2RpZVJlc3RvcmVFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://codecov.io/gh/apache/incubator-hudi/pull/1492/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGUuamF2YQ==) | `79.64% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/hudi/table/action/BaseActionExecutor.java](https://codecov.io/gh/apache/incubator-hudi/pull/1492/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL0Jhc2VBY3Rpb25FeGVjdXRvci5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/hudi/table/action/rollback/RollbackHelper.java](https://codecov.io/gh/apache/incubator-hudi/pull/1492/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL3JvbGxiYWNrL1JvbGxiYWNrSGVscGVyLmphdmE=) | `80.43% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...he/hudi/table/action/rollback/RollbackRequest.java](https://codecov.io/gh/apache/incubator-hudi/pull/1492/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL3JvbGxiYWNrL1JvbGxiYWNrUmVxdWVzdC5qYXZh) | `94.73% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...java/org/apache/hudi/client/HoodieWriteClient.java](https://codecov.io/gh/apache/incubator-hudi/pull/1492/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZVdyaXRlQ2xpZW50LmphdmE=) | `66.58% <55.88%> (-2.65%)` | `0.00 <0.00> (ø)` | |
| [...tion/restore/CopyOnWriteRestoreActionExecutor.java](https://codecov.io/gh/apache/incubator-hudi/pull/1492/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL3Jlc3RvcmUvQ29weU9uV3JpdGVSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `75.00% <75.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...tion/restore/MergeOnReadRestoreActionExecutor.java](https://codecov.io/gh/apache/incubator-hudi/pull/1492/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL3Jlc3RvcmUvTWVyZ2VPblJlYWRSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `75.00% <75.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...le/action/rollback/BaseRollbackActionExecutor.java](https://codecov.io/gh/apache/incubator-hudi/pull/1492/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL3JvbGxiYWNrL0Jhc2VSb2xsYmFja0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `77.77% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [18 more](https://codecov.io/gh/apache/incubator-hudi/pull/1492/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1492?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1492?src=pr&el=footer). Last update [a464a29...6e48a53](https://codecov.io/gh/apache/incubator-hudi/pull/1492?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services