You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2023/04/08 01:27:15 UTC

[GitHub] [doris] morningman commented on a diff in pull request #18417: [fix](fe) add fe isReady check before getMasterIp

morningman commented on code in PR #18417:
URL: https://github.com/apache/doris/pull/18417#discussion_r1161041880


##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/GetLoadInfoAction.java:
##########
@@ -77,9 +77,13 @@ public Object execute(
             return new RestBaseResult("No cluster selected");
         }
 
-        RedirectView redirectView = redirectToMaster(request, response);
-        if (redirectView != null) {
-            return redirectView;
+        try {

Review Comment:
   I think we'd better extract a common method to handle this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org