You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "paulk-asert (via GitHub)" <gi...@apache.org> on 2023/09/07 04:34:46 UTC
[GitHub] [groovy] paulk-asert opened a new pull request, #1948: GROOVY-11167: JsonOutput should handle Records like POGOs
paulk-asert opened a new pull request, #1948:
URL: https://github.com/apache/groovy/pull/1948
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] daniellansun commented on a diff in pull request #1948: GROOVY-11167: JsonOutput should handle Records like POGOs
Posted by "daniellansun (via GitHub)" <gi...@apache.org>.
daniellansun commented on code in PR #1948:
URL: https://github.com/apache/groovy/pull/1948#discussion_r1318110909
##########
src/main/java/org/codehaus/groovy/vmplugin/VMPlugin.java:
##########
@@ -179,4 +181,17 @@ static String getJavaVersion() {
default Map<String, Set<String>> getDefaultImportClasses(String[] packageNames) {
return Collections.emptyMap();
}
+
+ /**
+ * Returns the list of record component names or the empty list if
+ * the class is not a record or running on a pre16 JDK.
+ *
+ * @param maybeRecord the class in question
+ * @return the default list of names
+ * @since 4.0.14
Review Comment:
4.0.14 was released, so the version should be 4.0.15?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1948: GROOVY-11167: JsonOutput should handle Records like POGOs
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert merged PR #1948:
URL: https://github.com/apache/groovy/pull/1948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on a diff in pull request #1948: GROOVY-11167: JsonOutput should handle Records like POGOs
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert commented on code in PR #1948:
URL: https://github.com/apache/groovy/pull/1948#discussion_r1318268847
##########
src/main/java/org/codehaus/groovy/vmplugin/VMPlugin.java:
##########
@@ -179,4 +181,17 @@ static String getJavaVersion() {
default Map<String, Set<String>> getDefaultImportClasses(String[] packageNames) {
return Collections.emptyMap();
}
+
+ /**
+ * Returns the list of record component names or the empty list if
+ * the class is not a record or running on a pre16 JDK.
+ *
+ * @param maybeRecord the class in question
+ * @return the default list of names
+ * @since 4.0.14
Review Comment:
Indeed, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org