You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rd...@apache.org on 2009/05/11 11:46:33 UTC
svn commit: r773513 - in /james/imap/trunk:
decode/src/main/java/org/apache/james/imap/decode/DecodingException.java
mailbox/src/main/java/org/apache/james/imap/mailbox/MailboxException.java
Author: rdonkin
Date: Mon May 11 09:46:30 2009
New Revision: 773513
URL: http://svn.apache.org/viewvc?rev=773513&view=rev
Log:
Default just in case no one read the javadocs. IMAP-72 https://issues.apache.org/jira/browse/IMAP-72
Modified:
james/imap/trunk/decode/src/main/java/org/apache/james/imap/decode/DecodingException.java
james/imap/trunk/mailbox/src/main/java/org/apache/james/imap/mailbox/MailboxException.java
Modified: james/imap/trunk/decode/src/main/java/org/apache/james/imap/decode/DecodingException.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/decode/src/main/java/org/apache/james/imap/decode/DecodingException.java?rev=773513&r1=773512&r2=773513&view=diff
==============================================================================
--- james/imap/trunk/decode/src/main/java/org/apache/james/imap/decode/DecodingException.java (original)
+++ james/imap/trunk/decode/src/main/java/org/apache/james/imap/decode/DecodingException.java Mon May 11 09:46:30 2009
@@ -69,6 +69,13 @@
* @return the key, not null
*/
public final HumanReadableTextKey getKey() {
+ final HumanReadableTextKey key;
+ if (this.key == null) {
+ // API specifies not null but best to default to generic message
+ key = HumanReadableTextKey.ILLEGAL_ARGUMENTS;
+ } else {
+ key = this.key;
+ }
return key;
}
Modified: james/imap/trunk/mailbox/src/main/java/org/apache/james/imap/mailbox/MailboxException.java
URL: http://svn.apache.org/viewvc/james/imap/trunk/mailbox/src/main/java/org/apache/james/imap/mailbox/MailboxException.java?rev=773513&r1=773512&r2=773513&view=diff
==============================================================================
--- james/imap/trunk/mailbox/src/main/java/org/apache/james/imap/mailbox/MailboxException.java (original)
+++ james/imap/trunk/mailbox/src/main/java/org/apache/james/imap/mailbox/MailboxException.java Mon May 11 09:46:30 2009
@@ -52,6 +52,13 @@
* @return the key, possibly null
*/
public final HumanReadableTextKey getKey() {
+ final HumanReadableTextKey key;
+ if (this.key == null) {
+ // API specifies not null but best to default to generic message
+ key = HumanReadableTextKey.GENERIC_FAILURE_DURING_PROCESSING;
+ } else {
+ key = this.key;
+ }
return key;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org