You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/01/27 19:42:43 UTC

[GitHub] [helix] NealSun96 commented on pull request #1945: Refactor and move ClusterTopologyConfig from nested class to a separate one.

NealSun96 commented on pull request #1945:
URL: https://github.com/apache/helix/pull/1945#issuecomment-1023577180


   @qqu0127 Looks good to me except the issue @zhangmeng916 raised. Please also check the boxes in the PR description before final checkin (btw, I think the first paragraph you have should be merged into the Description section). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org