You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/04/23 22:58:39 UTC
[jira] [Commented] (STORM-796) The "error" command isn't supported on ShellSpout

    [ https://issues.apache.org/jira/browse/STORM-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509788#comment-14509788 ] 

ASF GitHub Bot commented on STORM-796:
--------------------------------------

GitHub user amontalenti opened a pull request:

    https://github.com/apache/storm/pull/533

    Add support for "error" command in ShellSpout

    Addresses JIRA issue [STORM-796](https://issues.apache.org/jira/browse/STORM-796). 
    
    The symptoms a multi-lang user will see here is that if their Spout throws an error and their multi-lang implementation sends an "error" command up to the ShellSpout, the ShellSpout will respond saying that it doesn't recognize the "error" command, and thus it will crash (while swallowing the exception thrown by the underlying multi-lang component).
    
    ShellBolt already supports the error command, and ShellSpout already has a way of reporting errors -- so this was just a matter of adding similar logic to the ShellSpout.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amontalenti/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/533.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #533
    
----
commit 2c35cb4dec67604185d3b443a3e04a66fd4a6a6d
Author: Andrew Montalenti <an...@parsely.com>
Date:   2015-04-23T20:41:39Z

    add support for "error" command in ShellSpout

----


> The "error" command isn't supported on ShellSpout
> -------------------------------------------------
>
>                 Key: STORM-796
>                 URL: https://issues.apache.org/jira/browse/STORM-796
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.9.4
>            Reporter: Andrew Montalenti
>            Assignee: Andrew Montalenti
>             Fix For: 0.10.0
>
>
> The `ShellBolt` can handle the "error" command, as shown in this file in Storm source code:
> https://github.com/apache/storm/blob/2dd7a9426e5634211f14cf5c4e10e021d3420c3c/storm-core/src/jvm/backtype/storm/task/ShellBolt.java#L330
> But, `ShellSpout` does not actually have a handler for "error".
> https://github.com/apache/storm/blob/2dd7a9426e5634211f14cf5c4e10e021d3420c3c/storm-core/src/jvm/backtype/storm/spout/ShellSpout.java#L153-L175
> The symptoms a multi-lang user will see here is that if their Spout throws an error and their multi-lang implementation sends an "error" command up to the ShellSpout, the ShellSpout will respond saying that it doesn't recognize the "error" command, and thus it will crash (while swallowing the exception thrown by the underlying multi-lang component).
> I am about to open a PR on Github that fixes this.
> Originally reported on the streamparse project in this Github issue:
> https://github.com/Parsely/streamparse/issues/121



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)