[jira] [Commented] (HTRACE-153) htrace-c should compile with -Pnative on Mac

["Colin P. McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735876#comment-15735876 ] 

Colin P. McCabe commented on HTRACE-153:
----------------------------------------

I have a patch for this, which I tested out locally.

* CMakeLists.txt: Check whether sys/prctl.h exists, and avoid using prctl if it does not.

* CMakeLists.txt: Check in /usr/local/include and /usr/local/lib for dependencies.  These seem to be standard-ish places to install dependencies on MacOS X.

* core/htrace.hpp: This should include stream, since it's using ostreams.  For some reason, this works on Linux (probably because someone else is including stream for us).

* receiver/hrpc.c: MacOS needs #include <sys/uio.h> to get access to the writev function that we need.

* receiver/hrpc.c: Move the endian.h functions into a separate file, util/endian.h, and add support for MacOS X.

* receiver/htraced.c: MacOS doesn't define the standard pthread_yield function.  Use the platform-specific sched_yield instead

* receiver/receiver.h: The external htrace_rcv_ty objects need "extern" here.

* Unit tests: use typecasts to avoid annoying warnings about comparing long and long long.

* util/tracer_id.c: IN6_IS_ADDR_LOOPBACK doesn't work without the macros in util.net.h

> htrace-c should compile with -Pnative on Mac
> --------------------------------------------
>
>                 Key: HTRACE-153
>                 URL: https://issues.apache.org/jira/browse/HTRACE-153
>             Project: HTrace
>          Issue Type: Bug
>    Affects Versions: 3.2.0
>            Reporter: Abraham Elmahrek
>            Assignee: Colin P. McCabe
>         Attachments: HTRACE-153.001.patch
>
>
> The C and C++ code in htrace-c should compile on Mac OS X.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)