You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "fardin-developer (via GitHub)" <gi...@apache.org> on 2025/02/11 20:47:21 UTC
[PR] Update 'Last modified' time when modifying RLS rules [superset]
fardin-developer opened a new pull request, #32227:
URL: https://github.com/apache/superset/pull/32227
Fixes #32050
### SUMMARY
This PR fixes an issue where the Last modified field does not update when a Row Level Security (RLS) rule is changed. The issue occurs because the modification timestamp is not being updated in the database when an RLS rule is altered.
### CHANGES
- Ensure the **Last modified** field is updated when an RLS rule is **created or edited**.
## STEPS TO REPRODUCE
1. Navigate to **Settings → Row Level Security**.
2. Create a new RLS rule by clicking the **"+ Rule"** button in the top-right corner.
3. Observe the **Last modified** field.
4. Modify the rule and save the changes.
5. The **Last modified** field should reflect the latest update.
### BEFORE/AFTER SCREENSHOTS
#### Before
#### After
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Update 'Last modified' time when modifying RLS rules [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #32227:
URL: https://github.com/apache/superset/pull/32227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Update 'Last modified' time when modifying RLS rules [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #32227:
URL: https://github.com/apache/superset/pull/32227#issuecomment-2652041591
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/32227?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 65.51%. Comparing base [(`76d897e`)](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`8eb651e`)](https://app.codecov.io/gh/apache/superset/commit/8eb651ea0a212993f99df4958d1d4f6413162e0e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1436 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #32227 +/- ##
==========================================
+ Coverage 60.48% 65.51% +5.03%
==========================================
Files 1931 546 -1385
Lines 76236 39074 -37162
Branches 8568 0 -8568
==========================================
- Hits 46114 25601 -20513
+ Misses 28017 13473 -14544
+ Partials 2105 0 -2105
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/32227/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/32227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <ø> (-0.65%)` | :arrow_down: |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/32227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/32227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.05% <ø> (-0.75%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/32227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.51% <ø> (+2.03%)` | :arrow_up: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/32227/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `61.06% <ø> (+3.43%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/32227?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org