You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/01/23 16:51:50 UTC
[GitHub] [groovy] eric-milles opened a new pull request #1151: ASM: remove
push/pop for if/else blocks
eric-milles opened a new pull request #1151: ASM: remove push/pop for if/else blocks
URL: https://github.com/apache/groovy/pull/1151
Extra bytecode instructions are written for if and else blocks. Removing push/pop does not appear to affect behavior.
```groovy
boolean boolVar = false
if (boolVar) {
}
```
```
3 astore_1
4 iconst_0
5 istore_2 [boolVar]
6 iload_2 [boolVar] // excess from pushBooleanExpression()
7 pop // excess from pop()
8 iload_2 [boolVar]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] danielsun1106 commented on issue #1151: ASM: remove
push/pop for if/else blocks
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on issue #1151: ASM: remove push/pop for if/else blocks
URL: https://github.com/apache/groovy/pull/1151#issuecomment-578102238
Merged. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] danielsun1106 merged pull request #1151: ASM: remove
push/pop for if/else blocks
Posted by GitBox <gi...@apache.org>.
danielsun1106 merged pull request #1151: ASM: remove push/pop for if/else blocks
URL: https://github.com/apache/groovy/pull/1151
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services